You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Type-check with bun --check; drop the helper script - #181
typecheck runs bun --check --tsconfig-override tsconfig.json, which runs Bun's type checker even though package.json has a check script. It replaces scripts/typecheck.ts, which spawned bun check from the temporary directory to get around that script. The new form needs no helper, prints repository-relative paths and has no shell syntax, so it runs the same on Windows.
A deliberate type error makes bun run typecheck exit 1; bun run check passes locally (128 files). The Windows CI job runs the same script.
Summary by cubic
Type-checks with bun --check --tsconfig-override tsconfig.json instead of bun scripts/typecheck.ts, and removes the helper script. The old script spawned bun check from a temporary directory to dodge the package.json check script shadowing Bun's built-in. The new command needs no shell syntax, prints repository-relative paths, and behaves the same on Windows.
bun run typecheck still exits 1 on a deliberate type error, and bun run check passes locally (128 files).
Written for commit 872b6a6. Summary will update on new commits.
Summary by CodeRabbit
Chores
Updated the project’s type-checking workflow to use Bun’s built-in check command. This is a development workflow change and does not affect the app’s user-facing features or behavior.
Reviewing files that changed from the base of the PR and between 408436a and 872b6a6.
📒 Files selected for processing: 2
package.json
scripts/typecheck.ts
💤 Files with no reviewable changes: 1
scripts/typecheck.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
The typecheck script now runs Bun’s built-in check command with tsconfig.json. The script no longer uses scripts/typecheck.ts.
Changes: Typecheck command
Layer / File(s)
Summary
Run typecheck directly package.json, scripts/typecheck.ts
The typecheck command now uses bun --check --tsconfig-override tsconfig.json. The wrapper script is deleted.
Priority: ⬇️ Low
Merge Risk:⚪ Minimal · up to 872b6
The typecheck command preserves project checking and failure reporting in CI; no concrete merge-blocking risk remains.
### Architecture Summary
Architecture risk:🔵 Low · up to 872b6
The change affects 2 systems.
Changed systems:package.json, scripts
Architecture concerns
No architecture-level concerns identified.
Review details
Systems and components
observed — package.json (service) was modified; 1 changed file maps to changed impact.
observed — scripts (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
observed — Modified behavior in package.json: The typecheck command changes from bun scripts/typecheck.ts to bun --check --tsconfig-override tsconfig.json.
observed — Modified behavior in scripts/typecheck.ts: The script that spawned Bun’s built-in check with the project tsconfig.json, ran it from the temporary directory, forwarded its output streams, and propagated its exit code was deleted.
Pre-merge checks: 6
Check name
Status
Explanation
Title check
The title clearly and concisely identifies the main change: using Bun's type checker and removing the helper script.
Description check
The description explains the implementation, rationale, removed helper, platform behavior, and validation results. It does not include the repository template checklist, but the substantive required i…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Suppressions Explained
The pull request changes only the typecheck script command and deletes the helper. It adds no lint, type-check, formatter suppression directive, or ignore entry.
Interface Changes Documented
The diff changes only the package typecheck script and deletes scripts/typecheck.ts. It does not add, remove, or rename an MCP tool or argument, a swarmail command or flag, or an environment var…
Full details: Description check
Explanation
The description explains the implementation, rationale, removed helper, platform behavior, and validation results. It does not include the repository template checklist, but the substantive required information is mostly present.
Full details: Interface Changes Documented
Explanation
The diff changes only the package typecheck script and deletes scripts/typecheck.ts. It does not add, remove, or rename an MCP tool or argument, a swarmail command or flag, or an environment variable. The documentation updates are therefore not required by this check.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typecheckrunsbun --check --tsconfig-override tsconfig.json, which runs Bun's type checker even though package.json has acheckscript. It replacesscripts/typecheck.ts, which spawnedbun checkfrom the temporary directory to get around that script. The new form needs no helper, prints repository-relative paths and has no shell syntax, so it runs the same on Windows.A deliberate type error makes
bun run typecheckexit 1;bun run checkpasses locally (128 files). The Windows CI job runs the same script.Summary by cubic
Type-checks with
bun --check --tsconfig-override tsconfig.jsoninstead ofbun scripts/typecheck.ts, and removes the helper script. The old script spawnedbun checkfrom a temporary directory to dodge the package.jsoncheckscript shadowing Bun's built-in. The new command needs no shell syntax, prints repository-relative paths, and behaves the same on Windows.bun run typecheckstill exits 1 on a deliberate type error, andbun run checkpasses locally (128 files).Written for commit 872b6a6. Summary will update on new commits.
Summary by CodeRabbit