Skip to content

Type-check with bun --check; drop the helper script - #181

Merged
bompus merged 1 commit into
mainfrom
bun-check-flag
Oct 19, 2026
Merged

bompus merged 1 commit into
mainfrom
bun-check-flag

Conversation

@bompus

@bompus bompus commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

typecheck runs bun --check --tsconfig-override tsconfig.json, which runs Bun's type checker even though package.json has a check script. It replaces scripts/typecheck.ts, which spawned bun check from the temporary directory to get around that script. The new form needs no helper, prints repository-relative paths and has no shell syntax, so it runs the same on Windows.

A deliberate type error makes bun run typecheck exit 1; bun run check passes locally (128 files). The Windows CI job runs the same script.


Summary by cubic

Type-checks with bun --check --tsconfig-override tsconfig.json instead of bun scripts/typecheck.ts, and removes the helper script. The old script spawned bun check from a temporary directory to dodge the package.json check script shadowing Bun's built-in. The new command needs no shell syntax, prints repository-relative paths, and behaves the same on Windows.

bun run typecheck still exits 1 on a deliberate type error, and bun run check passes locally (128 files).

Written for commit 872b6a6. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Chores
    • Updated the project’s type-checking workflow to use Bun’s built-in check command. This is a development workflow change and does not affect the app’s user-facing features or behavior.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bompus has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@bompus

bompus commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9aaf2cfa-1ce7-4df8-8fbf-18612c41210a
📥 Commits

Reviewing files that changed from the base of the PR and between 408436a and 872b6a6.

📒 Files selected for processing: 2
  • package.json
  • scripts/typecheck.ts
💤 Files with no reviewable changes: 1
  • scripts/typecheck.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The typecheck script now runs Bun’s built-in check command with tsconfig.json. The script no longer uses scripts/typecheck.ts.

Changes: Typecheck command

Layer / File(s) Summary
Run typecheck directly
package.json, scripts/typecheck.ts
The typecheck command now uses bun --check --tsconfig-override tsconfig.json. The wrapper script is deleted.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 872b6

The typecheck command preserves project checking and failure reporting in CI; no concrete merge-blocking risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 872b6

The change affects 2 systems.

Changed systems: package.json, scripts

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — package.json (service) was modified; 1 changed file maps to changed impact.
  • observed — scripts (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in package.json: The typecheck command changes from bun scripts/typecheck.ts to bun --check --tsconfig-override tsconfig.json.
  • observed — Modified behavior in scripts/typecheck.ts: The script that spawned Bun’s built-in check with the project tsconfig.json, ran it from the temporary directory, forwarded its output streams, and propagated its exit code was deleted.
Pre-merge checks: Passed 6
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: using Bun's type checker and removing the helper script.
Description check Passed The description explains the implementation, rationale, removed helper, platform behavior, and validation results. It does not include the repository template checklist, but the substantive required i…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Suppressions Explained Passed The pull request changes only the typecheck script command and deletes the helper. It adds no lint, type-check, formatter suppression directive, or ignore entry.
Interface Changes Documented Passed The diff changes only the package typecheck script and deletes scripts/typecheck.ts. It does not add, remove, or rename an MCP tool or argument, a swarmail command or flag, or an environment var…
Full details: Description check

Explanation

The description explains the implementation, rationale, removed helper, platform behavior, and validation results. It does not include the repository template checklist, but the substantive required information is mostly present.

Full details: Interface Changes Documented

Explanation

The diff changes only the package typecheck script and deletes scripts/typecheck.ts. It does not add, remove, or rename an MCP tool or argument, a swarmail command or flag, or an environment variable. The documentation updates are therefore not required by this check.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@bompus
bompus merged commit 5c98a1f into main Oct 19, 2026
4 checks passed
@bompus
bompus deleted the bun-check-flag branch October 19, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant