Repository navigation
docs(hr-benchmarking): add profile viewing and off-CPU guidance - #323
Merged
Merged
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds commands and interpretation limits for local profile viewing, mixed native/JavaScript CPU attribution, allocation tracing and off-CPU analysis to the existing benchmarking tool reference. The additions come from a completed diagnostic trial; no benchmark improvement is claimed.
The reference now names speedscope, preserves default perf-script formatting for import, describes
perf report --no-inline, explains heaptrack overhead, and pairs oha latency correction with its required rate limit. No tool becomes a benchmark prerequisite.Validation on 5e97936: Node suite 151 pass / 7 skip; Bun suite 488 pass / 8 skip; skill scripts 338 pass; npm package check passed (235 files); pinned formatter passed. Pinned oxlint exited 0 with the existing no-control-regex warning in test/install-ps1.test.mjs. A real local speedscope import and scheduler-tracing smoke run also passed.
Review correction: the profileURL hash value is now encoded with encodeURIComponent, preserving nested query parameters. Confirmed in the packaged parser and a browser import with two query parameters. Focused formatting, privacy and local-link checks passed after the wording correction; no manual follow-up review was requested.
Summary by CodeRabbit
perf.ohalatency correction requires fixed-rate mode (-q) to take effect.