Repository navigation
feat(hr-handoff): successor thread title, rotation trigger, boundary and record - #322
Merged
Merged
Conversation
…trigger, boundary and record
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hr-handoffnow says how to replace a session with a successor thread: the title, when stale guidance is worth a new session, when it is safe, and what the handoff and successor record.Nothing in
rules/or another skill covered this. I searchedrules/andskills/for handoff, successor, rotate and rotation. The matches were the low-quota modifier, the plan-files modifier,hr-what-nextand the existing thread-move step inhr-handoff, none of which set a title, a trigger or a boundary for replacing a session.hr-agent-guidance-refreshonly says a reread does not prove injected context changed. The new text is a reference file inhr-handoff, linked fromSKILL.md, so it sits beside the thread-move step it extends. No host tool calls are in it, so any host can use it.v<N>. The first thread counts asv1and is renamed at the handoff. A trailingv<digits>is parsed and incremented. Threads are found by registry row, project and thread id, never by title.gomeans. The successor re-points registry rows, scheduled tasks, pull request watches and its messaging name, with read-backs.Choices made in passing:
gomeans when several listed offers are open, matching § Offers.descriptionis unchanged, so skill selection should not shift.Checks on this head:
node --test test/*.test.mjs(151 pass, 7 skipped),bun test test/ skills/(488 pass, 8 skipped, 0 fail),npm run check:package -- --bun, pinnedoxfmtcheck clean, pinnedoxlint(one existing warning intest/install-ps1.test.mjs, not touched here), and the plain-prose checker on the new file. Not covered: host adoption, and the host-specific tool steps, which the chief-of-staff Orchestrator writes.Summary by cubic
Adds successor-thread guidance to
hr-handofffor replacing a session when stale injected guidance warrants it, covering the successor title, the rotation trigger, the safe boundary, and what the handoff and successor record. The new referencesuccessor-thread.mdis linked fromSKILL.mdand makes no host tool calls, so any host can use it.v<N>; the first thread counts asv1and is renamed at the handoff. Threads are found by registry row, project and thread id, never by title.goselects only when one listed offer is open. The outgoing thread is marked settled with a pointer to the successor, who re-points registry rows, scheduled tasks, pull request watches and its messaging name; items it cannot bind keep the recorded reason and stay behind.Written for commit eb30674. Summary will update on new commits.
Summary by CodeRabbit