Skip to content

Fix Activate for selected printer units #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boingball merged 1 commit into from
Sep 4, 2026
Merged

Fix Activate for selected printer units #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/MintPrintSettings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10300,22 +10300,26 @@ void process_window_events(struct Window *win) {
custom_printf("Unit%d has no saved settings yet - nothing to activate.\n",
current_unit_index);
} else {
char src_config[64];
int selected_unit = current_unit_index;
char dst_env[64], dst_envarc[64];
BOOL ok;

unit_config_path(0, FALSE, dst_env, sizeof(dst_env));
unit_config_path(0, TRUE, dst_envarc, sizeof(dst_envarc));

/* Activate the settings currently loaded in the
* GUI directly. The previous implementation copied
* UnitN through a .new/.bak Rename() sequence;
* that is not reliable on all ENV:/ENVARC:
* handlers and hid the failing operation behind
* the generic "Could not copy" message. */
capture_driver_settings(win);
current_unit_index = 0;
ok = ensure_config_dir((CONST_STRPTR)"ENV:MintPRINT") &&
ensure_config_dir((CONST_STRPTR)"ENVARC:MintPRINT") &&
unit_config_source_path(current_unit_index,
src_config,
sizeof(src_config)) &&
mp_copy_file((CONST_STRPTR)src_config,
(CONST_STRPTR)dst_env) &&
mp_copy_file((CONST_STRPTR)src_config,
(CONST_STRPTR)dst_envarc);
write_driver_config_file((CONST_STRPTR)dst_env) &&
write_driver_config_file((CONST_STRPTR)dst_envarc);
current_unit_index = selected_unit;

if (ok) {
char src_cache_env[64], src_cache_envarc[64];
Expand Down
Loading