Fix #95: engine-aware 360/720 DPI support - #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Issue #95 DPI support on top of the current slow-Canon work in #94.
This PR deliberately targets
fix/canon-large-job-upload, so its diff is only the DPI work. Once #94 is ready, this can be merged into it without losing the Canon large-job/back-pressure changes.What changes
urf-supportedRS...resolution valuespwg-raster-document-resolution-supportedfor PWG when the printer supplies itprinter-resolution-supportedfor older/incomplete printers and legacy capability cachesRESOLUTION=360orRESOLUTION=720back to 300Epson ET-2850 / #95
The supplied probe reports generic
360x360and720x720, but PWG Raster reports only360x360and URF reportsRS360. Accordingly MintPRINT will not blindly send a 720-DPI PWG/URF stream that the decoder did not advertise. On this printer PWG/URF should offer reported 360 DPI plus the existing marked 300* compatibility choice; engines using the generic resolution capability can offer 360/720.Regression safety
The branch is based exactly on #94 head
1a3193a32e30f6be52125a22357d5182b4eaa6eb.Full host-side
make checkpasses after the patch, including DPI, JPEG, URF, media-size, HTTP/IPP parsing, mDNS, PostScript and graphics-boundary regressions.Fixes #95