Repository navigation
App beta backprop - #51
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
converge to a physically wrong, inverted arc — a failure mode on off-apex images or with
loose parameter bounds. The penalty detects this by checking whether the predicted arc
curves in the correct direction relative to its chord, and adds a large cost when it does
not. Enabled by default; configurable via
concavity_penalty(bool) andconcavity_penalty_scale(float) kwargs infit_arc(). The correct curvature directionis auto-detected from
theta_z, so non-standard viewing geometries (e.g. camera pointingaway from nadir) are handled correctly without any user configuration.
Changed
fit_sagitta) upgraded from a 2-D to a 3-D optimisation: the arcapex x-position is now a free parameter alongside curvature and camera angle. This removes
a systematic radius bias on asymmetric arcs whose true apex falls outside the annotated
region.
computed camera angle (
arccos(r / (r + h))) rather than the raw optimiser estimate,avoiding a near-degeneracy that could misguide the final fit.