Skip to content

Fix KeyError When Chaining PARTITION on a Redefined/Transformed Term - #592

Merged
hadia206 merged 2 commits into
mainfrom
Hadia/fix_chained_partition
Oct 13, 2026
Merged

hadia206 merged 2 commits into
mainfrom
Hadia/fix_chained_partition

Conversation

@hadia206

@hadia206 hadia206 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Linked ticket

Closes #590

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Docs / config

What changed and why?

Chaining a second PARTITION on top of a PARTITION whose key comes from a CALCULATE that redefines a term using its own old value raised an unhandled KeyError. Same problem as #557 but on a different path.

Fixed by making the second path match the first one.

How I tested this?

  • Added reproducible test

Notes for reviewers

@hadia206 hadia206 changed the title [run all] fix and test Fix KeyError When Chaining PARTITION on a Redefined/Transformed Term Oct 9, 2026
@hadia206 hadia206 changed the title Fix KeyError When Chaining PARTITION on a Redefined/Transformed Term Fix KeyError When Chaining PARTITION on a Redefined/Transformed Term Oct 9, 2026
@hadia206
hadia206 marked this pull request as ready for review October 9, 2026 22:32
@hadia206
hadia206 requested review from a team, john-sanchez31, juankx-bodo and knassre-bodo and removed request for a team October 9, 2026 22:32

@john-sanchez31 john-sanchez31 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Hadia!

@juankx-bodo juankx-bodo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hadia206
hadia206 merged commit 021ea47 into main Oct 13, 2026
18 checks passed
@hadia206
hadia206 deleted the Hadia/fix_chained_partition branch October 13, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chained .PARTITION() operations fail on redefined/transformed terms (CALCULATE(x=FUNC(x)))

3 participants