Fix table lookup for FileSystemCatalog with S3 path - #1411
Merged
scott-routledge2 merged 6 commits intoSep 24, 2026
Merged
Conversation
IsaacWarren
approved these changes
Sep 24, 2026
|
|
||
| <dependency> | ||
| <groupId>com.amazonaws</groupId> | ||
| <artifactId>aws-java-sdk-dynamodb</artifactId> |
Contributor
There was a problem hiding this comment.
Why do we need dynamodb?
Contributor
Author
There was a problem hiding this comment.
I'm not sure, I saw the error after adding s3.
I'll investigate a bit more.
Contributor
Author
There was a problem hiding this comment.
From the error, it looks like dynamo might be a dependency of hadoop.fs.s3a.S3AFileSystem.
And we are seeing these errors in the first place because we are explicitly excluding the aws-java-sdk-bundled dependency--
I am assuming this is to keep our JAR size small?
Contributor
There was a problem hiding this comment.
Yeah it's for jar size
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
+ Coverage 66.55% 68.16% +1.61%
==========================================
Files 198 198
Lines 68731 68998 +267
Branches 9834 9908 +74
==========================================
+ Hits 45744 47034 +1290
+ Misses 20071 19089 -982
+ Partials 2916 2875 -41 |
scott-routledge2
marked this pull request as ready for review
September 24, 2026 21:15
scott-routledge2
deleted the
scott/add_bodosql_missing_aws_depedencies
branch
September 24, 2026 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
Testing strategy
New test added:
User facing changes
Checklist
[run CI]in your commit message.