Skip to content

security(network): retire stale Samba controls (NET-11) - #633

Merged
boburning merged 1 commit into
mainfrom
feature/net11-audit-samba-ui
Aug 31, 2026
Merged

boburning merged 1 commit into
mainfrom
feature/net11-audit-samba-ui

Conversation

@boburning

Copy link
Copy Markdown
Owner

Program mapping

NET-11 stable-payload completion. This follows the rejected inherited Samba candidate recorded by #618 and is independent on current main (a811215d30da162e3fa461cec1aa0c30cc6db196). It is not stacked on an unmerged branch.

Closes #632.

Summary

  • remove the inherited writable smb.conf from the stable payload
  • remove unreachable Samba start/auth compatibility logic and stop advertising retired listener toggles in compatibility help
  • remove the Samba state/share parser, Tweaks menu/toggle, and default credentials
  • replace current enablement guidance with explicit retirement guidance and the reviewed key-only SFTP route
  • retain migration-only .smbdState cleanup, exact inherited smbd termination, the uncertified-service migration, historical versioned evidence, and non-shipping feasibility tooling
  • keep packaging/provenance exhaustive and CI risk scoping explicit for any future Samba-path change

Validation

  • 48/48 focused listener, Samba, branding, manifest, provenance, FAT-payload, and CI tests
  • 18/18 focused Samba and legacy-manifest tests after the final compatibility-help correction
  • 3/3 RetroArch build-identity tests
  • exhaustive Shell: 814/814 across eight bounded shards; zero not ok; all shard statuses zero
  • native: 595/595 in 18.64 seconds
  • AddressSanitizer: 595/595 in 31.95 seconds with leak detection and halt-on-error enabled
  • focused cppcheck for src/tweaks: passed in 1.09 seconds (pre-existing style notes only)
  • pinned ARM toolchain: stripped 32-bit ARM EABI5 Tweaks executable, SHA-256 2da59143d3fc57dbeb18602d8f3b35f8c35c31ef220a04abf290cd0fe7f0d078
  • manifest/provenance: 331 components, 1,972 files, 260,958,446 bytes; 232 source-built and 99 unresolved components
  • CI scope: full ARM/native/shell/visual gates, src/tweaks static analysis, risk 3
  • git diff --check: passed

Device evidence

No device mutation was performed for this host-safe retirement slice. The Mini Plus remains on its retained signed baseline and existing recovery overlay. This PR makes no physical certification claim.

Limitations and follow-up

  • The signed integrated Full checkpoint remains pending; it must verify that older-card Samba remnants remain disabled and that rollback is intact.
  • Retained feasibility tooling is explicitly non-shipping and does not authorize a listener.
  • Mini Plus evidence will not certify Mini V1-V4 or Mini Flip behavior.

@boburning
boburning merged commit 2413b24 into main Aug 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NET-11: retire stale Samba controls and configuration

1 participant