Repository navigation
security(network): retire inherited FTP payload (NET-10) - #630
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- remove the inherited �ftpd and �ftpdutmp executables plus anonymous/authenticated FTP configurations from stable payloads\n- remove dormant FTP start/auth logic and the legacy Tweaks FTP menu, toggle, and default-credential copy\n- keep .ftpState / .authftpState migration cleanup and exact �ftpd termination so upgraded or rolled-back cards remain fail-closed\n- preserve the reviewed key-only SFTP implementation and replace current FTP guidance with an explicit migration route\n- regenerate the inherited inventory: 331 components, 1,972 files, 260,959,742 bytes; 232 source-built and 99 unresolved\n- keep deleted stable-payload paths on the exhaustive ARM/Shell gate while scoping cppcheck to affected Tweaks sources\n\n## Dependency / base\n\nIndependent NET-10 cleanup based directly on current main (�bd1b4348c936333e43b130d5493d9553e2ce7ff). It is not stacked on another open implementation PR.\n\n## Validation\n\n- focused listener/manifest/CI/provenance/FAT gates: 40/40 passed\n- focused branding plus listener regression: 11/11 passed\n- exhaustive Shell: 813/813 passed in 157.24 seconds\n- native: 595/595 passed in 56.45 seconds\n- AddressSanitizer: 595/595 passed in 71.88 seconds\n- est/test_ci_scope.sh: passed\n- RetroArch dependency-identity unit tests: 3/3 passed\n- scoped cppcheck (src/tweaks): passed in 1.45 seconds\n- ARM Tweaks cross-build: ELF 32-bit ARM EABI5, SHA-256 160a38cb2d663ea95c6fd635f20ecf7afd9eec9622b9e20b1f8707aeead4eb53\n- legacy manifest, development provenance closure, transfer policy, dependency inventory, and git diff --check: passed\n\n## Device evidence\n\nNo Mini Plus mutation, restart, overlay change, Wi-Fi change, or signed update was performed for this host-safe payload-retirement slice. Existing signed/overlay recovery state was deliberately preserved. The compatibility tests prove stale flags remain ignored and a running inherited �ftpd is still terminated, but this is host evidence, not physical certification.\n\n## Limitations / follow-up\n\n- no physical LCD/control or live port-21 observation is claimed\n- an older installed or rollback payload may still contain inherited bftpd bytes until a coherent signed Full update; current reconciliation remains fail-closed for those remnants\n- the integrated signed Mini Plus checkpoint remains separate and must verify installed-version, listener, rollback, and physical behavior without repeating the prior Wi-Fi/update-loop failure mode\n\nCloses #629