Repository navigation
fix(shell): redraw completed Wi-Fi timer state - #590
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PR #584 corrected the Wi-Fi event type from the invalid SDL 1.2 value 32 to valid user-event value 26. Current Mini Plus evidence confirms that correction works: the timer now polls and reaps the completed
bloomctl network connect statuschild.The same timer event carries no user action. Each Wi-Fi overlay therefore reached its final “active/open” catch-all and immediately
continued before the shared render call. After terminal polling removed the timer, no later event repainted the ready state, leaving the framebuffer permanently onChecking Wi-Fi safety...even though the backend had completed successfully.This correction identifies only
WIFI_EVENT_TYPEas a redraw event and exempts it from those six terminal no-action guards. It does not bypass action-specific validation or permit any additional input or network mutation.Host validation
-Wall -Wextra -Werror: passbloom_shell_settings.bats: 7/7 passgit diff --check: passDevice evidence before correction
bloomctl network connect statusreturned canonical idle/inactive JSON immediatelyChecking Wi-Fi safety..., proving the terminal controller state was not redrawnSigned device gate
29e79e5af3b210db193eb994834bb4bfe99e815fBloomOS-v0.1.0-dev-29e79e5a.zip, 199,851,472 bytes, SHA-2562506f87e2bd26f15ac3ddd7908c568d0da5de3ee0095ca259b0b38ebd07704c4ab9452a23bdb537513c8489023c22cd71929b1cff92358cbcd51a5384a5182f7; Ed25519 signature verified against the repository release public key0cff0cea29caf9110f009a5336057d4d8da61a5417d947a1789e178c25e620ba; release metadata and payload recomputation passed56540689853e387db76041a636934863b55d83397cf335379e9c51dcd7a5c4banet05-redraw-29e79e5a-20260830seeded five unchanged files and transferred only the signed Shell; prior signed fix(shell): keep Wi-Fi polling inside SDL 1.2 event range #584 overlay remains the rollback slot/tmppath, SHA-256640af072feec7a0fbfd3bc802f0e940f2df75cbaaec6be90ddc1343b1bcc2167, then removed itWi-Fi: On / Connected, opened detail, and captured both terminal and settled frames showingSaved networksandScan for networks; the staleChecking Wi-Fi safety...frame is gone192.168.1.180/24, and listener audit remained clean with reviewed key-only SSHsendkeysremained unchanged at SHA-256c244bff7f442a5e8e44b97b2db4a4b634d404ad116b45dfd80a2329b20098677Limitations
Related: #442, #544, #583, #584, #585, #588.