Repository navigation
ci: scope Bloom Shell entrypoint cppcheck - #586
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/bloomShell/main.cthrough cppcheck's owning translation unit instead of the entiresrc/bloomShelldirectoryThis is a focused continuation of the affected-component CI work in #571 and #573.
Measured cause and result
PR #584 changed four lines in
src/bloomShell/main.c, but its static-analysis resolver selected the entire Bloom Shell directory. Hosted cppcheck then spent 190 seconds in the analysis step and 3m24s in the job overall: https://github.com/boburning/BloomOS/actions/runs/33327223569With this branch's exact PR-only resolver output, reduced cppcheck 2.19 analyzes
src/bloomShell/main.cin 12.25 seconds locally. The equivalent #573 owning-file policy produced a 14-second hosted static-analysis job, so this removes the same avoidable directory expansion without changing compile or integration coverage.For the exact #584-shaped path set (
main.cplus its Shell regression test), the resolver now returns:bloomShellsrc/bloomShell/main.cBloomShell*:BloomFrontend*Validation
sh -n tools/ci-scope.sh: passtest/test_ci_scope.sh: passgit diff --check: passSafety and limitations
mainafter merged fix(device): recover wedged Shell restarts safely #585Related: #518, #520, #571, #573, #584.