Repository navigation
feat(network): derive safe Wi-Fi profile handles (NET-05) - #552
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wifi-handle containing 104 bits from a no-follow/dev/urandomcharacter deviceDependency and scope
Base: current
mainat49f0a8096bff9a9157e4ce176201d2f532bb74dd.Dependency: PR #551 is merged into the base. This is the next independent host-only NET-05 slice tracked by #544. It is not stacked on an unmerged branch.
The helper has no rendered or runtime consumer in this PR. It cannot scan, associate, restart or disable Wi-Fi, write a credential, forget a profile, reboot a device, or activate an update.
Validation
BloomShellWifiUi*native tests passed; 557 ms test executionBloomShellWifiUi*AddressSanitizer tests passed; 715 ms test execution--Werror-Wall -Wextra -Werrorhost compilationsrc/bloomShellscope completed successfully with only existing informational/style findingsBloomOS_Work_Program_v3.jsonpassed JSON parsinggit diff --checkpassedCurrent-head GitHub CI passed: formatting in 13 seconds, all affected shell tests in 45 seconds, the ARM/check build in 1 minute 12 seconds, native tests in 1 minute 15 seconds, AddressSanitizer in 1 minute 22 seconds, and scoped static analysis in 1 minute 45 seconds.
Device evidence
No device candidate was built, installed, or activated for this host-only slice. The connected Mini Plus was intentionally left on its known-good signed baseline; no SSH command, Wi-Fi transition, profile mutation, reboot, or update was performed. This PR therefore makes no physical-hardware certification claim.
Limitations and follow-up
/dev/urandommust be available as a no-follow character device when a new ID is required; failure is terminal and leaves the form clearedIssue: #544
Parent program: #434