fix: dispose description window when toggled off, not just hide it - #119
Merged
Conversation
On some Linux/X11 window managers, quickly hiding a JWindow shortly after showing it can leave a blank "ghost" window on screen that is never un-mapped or repainted. Disposing of the description window's native peer when it's toggled off, instead of merely calling setVisible(false), avoids this. The window is lazily recreated the next time it's needed. Fixes #84 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoCompletion.setShowDescWindow(false)now disposes the description window's native peer (AutoCompletePopupWindow.disposeDescWindow()) instead of relying onsetVisible(false), which can leave a stale, un-repainted window mapped on screen when aJWindow's visibility is toggled in quick succession (a known class of OpenJDK/X11 issues, e.g. JDK-8173332). The window is lazily recreated the next time it's needed.Test plan
AutoCompletionTest#setShowDescWindow_false_disposesExistingDescWindow, which shows the completion + description windows, toggles the description window off, and asserts the description window's native peer is disposed (not just hidden)../gradlew clean buildpasses (compiles, tests, checkstyle, spotbugs).🤖 Generated with Claude Code