fix: include first overload when searching for matching completions - #118
Merged
Merged
Conversation
The backward search for sibling overloads in getCompletionsImpl() stopped at pos>0 instead of pos>=0, so the completion at index 0 of a matching group was never checked or added, even when it matched. Fixes #101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractCompletionProvider.getCompletionsImpl()where the backward search for sibling overloads usedpos>0instead ofpos>=0, causing the completion at index 0 of a matching group to be silently dropped from results.Fixes #101
Test plan
AbstractCompletionProviderTest#getCompletions_allOverloadsReturned_evenTheFirstOneInTheList, verified it fails against the pre-fix code and passes with the fix../gradlew :AutoComplete:testpasses.