[conversion] fix: skip absent auto mappings across PP - #6
Draft
bobboli wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip an automatic parameter mapping when its Megatron parameter is absent from every pipeline stage. Other mappings continue to require the parameter on at least one PP rank.
This prevents an optional mapping from aborting Megatron-to-HF export with
Object must exist on at least one PP rank, while preserving the existing error for required explicit mappings.Stack
This PR is stacked on #3, which contains the DeepSeek V4 hash-layer config fix and the DSV4 Bridge backport below it.
Scope
This PR contains only the PP optional-mapping fix and its regression test. It intentionally excludes the unrelated nested
rope_thetaconfig change from the old combined branch.Validation
python -m pytest tests/unit_tests/models/test_param_mapping.py -q: 55 passed