no redundant allocation in text decoder via ArrayBuffer::data()#4670
no redundant allocation in text decoder via ArrayBuffer::data()#4670jedel1043 merged 4 commits intoboa-dev:mainfrom
ArrayBuffer::data()#4670Conversation
Test262 conformance changes
|
|
Just saw the work in #4650 , #4637, #4631 that all target basically the same area for different issues. And all of them still use the allocating version. |
jedel1043
left a comment
There was a problem hiding this comment.
Thank you for the contribution! Everything looks good, I just had a suggestion for the detached error message.
|
I'll merge this first. #4631 needs another review pass. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4670 +/- ##
==========================================
+ Coverage 47.24% 56.58% +9.33%
==========================================
Files 476 548 +72
Lines 46892 60066 +13174
==========================================
+ Hits 22154 33988 +11834
- Misses 24738 26078 +1340 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArrayBuffer::data()ArrayBuffer::data()
This Pull Request fixes #4362 .
Following the suggestion from @HalidOdat in #4358 .
Note that for
Utf16Be, thedecodefunction does in place swapping and thus requires mutability.