feat(timeline): day-resolution tooltip + phone-friendly rail and taps#133
Closed
bndct-devops wants to merge 1 commit into
Closed
feat(timeline): day-resolution tooltip + phone-friendly rail and taps#133bndct-devops wants to merge 1 commit into
bndct-devops wants to merge 1 commit into
Conversation
- The tooltip resolves the day under the cursor (date + that day's minutes, or "no reading" inside a gap) below the book totals — the per-day data was only legible as tick opacity before. - Phones (<480px container): the rail narrows 200->96px so the ribbon keeps the viewport; coarse-pointer taps inspect first (tooltip), navigate on the second tap on the same bar. Scroll or empty-space tap dismisses. Book-page activity sparkline (planned as part of this PR) was investigated and dropped: the per-book stats hero already charts per-day activity for both live sessions and imported page-stats (sessions are synthesized from page-stats), so the strip would duplicate an adjacent chart. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overnight run PR 2/12 — stacked on #132; merge in order.
What
Dropped from scope, deliberately
The book-page activity sparkline from the idea sheet is not in here: while building it I found the per-book stats hero already charts per-day activity for both data sources —
compute_book_reading_statssynthesizes sessions from imported page-stats, so even device-only books get the hero with its day chart. The strip would have been a duplicate chart directly under an identical one. Marked accordingly on the sheet; no code shipped for it.Verification