Skip to content

Remove CVC5 binary#198

Merged
mugdhadhole1 merged 2 commits into
mainfrom
internal/remove-cvc5-binary
Jun 23, 2026
Merged

Remove CVC5 binary#198
mugdhadhole1 merged 2 commits into
mainfrom
internal/remove-cvc5-binary

Conversation

@mugdhadhole1

Copy link
Copy Markdown
Contributor

Remove CVC5 binary

@mugdhadhole1 mugdhadhole1 requested a review from a team as a code owner June 15, 2026 12:11
@mugdhadhole1 mugdhadhole1 added the internal Affects the CI, tests or refactorings only, not relevant to the end-user label Jun 15, 2026

@phiwuu phiwuu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update CHANGELOG.md

Comment thread .github/workflows/ci.yml
Comment thread documentation/TUTORIAL-LINT.md Outdated
@SurajBDeore

Copy link
Copy Markdown

Do we need to update the changelog?

Comment thread trlc/trlc.py
@SurajBDeore

Copy link
Copy Markdown

These two docs currently tell slightly different stories about where CVC5 works.

In [TUTORIAL-CI.md:46], it says CVC5 is GNU/Linux only.
In [README.md:65], it just says CVC5 is required for verify, without that Linux-only note.
So readers can get confused.

@mugdhadhole1 mugdhadhole1 force-pushed the internal/remove-cvc5-binary branch from 967179c to aa4efa3 Compare June 19, 2026 08:58
Comment thread CHANGELOG.md Outdated
Comment thread bazel/_private/mode_test.py Outdated
@kedarnn

kedarnn commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Please remove second point from - https://github.com/bmw-software-engineering/trlc/blob/main/documentation/dev_setup.md#setup

@mugdhadhole1 mugdhadhole1 force-pushed the internal/remove-cvc5-binary branch from 841ae8d to 88f9596 Compare June 23, 2026 06:58
@mugdhadhole1 mugdhadhole1 force-pushed the internal/remove-cvc5-binary branch from 88f9596 to 0f807ae Compare June 23, 2026 07:29
@mugdhadhole1 mugdhadhole1 enabled auto-merge (squash) June 23, 2026 09:14
@mugdhadhole1 mugdhadhole1 merged commit f682ae4 into main Jun 23, 2026
23 checks passed
@mugdhadhole1 mugdhadhole1 deleted the internal/remove-cvc5-binary branch June 23, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Affects the CI, tests or refactorings only, not relevant to the end-user

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants