Support Baseline Id in lobster-codebeamer#587
Open
iceman-muc wants to merge 12 commits into
Open
Conversation
added 3 commits
May 20, 2026 10:49
- Add 'Querying at a Baseline' subsection to user manual
- Add baseline_id to Python API reference (Config params,
behavioral notes, error conditions)
- Remove baseline_id from report-ID query path (has no effect
on /reports/{id}/items endpoint; only works with cbQL strings)
- Add baseline_id=None to setUp (required positional field) - Add test_get_query_with_query_and_baseline_id: verifies baselineId is appended to URL when import_query is a cbQL string - Add test_get_query_with_ID_and_baseline_id: verifies baselineId is NOT appended when import_query is a numeric report ID
Replace %-style URL formatting with f-string (consistent with the int branch) while keeping baseline_id logic intact.
phiwuu
requested changes
May 27, 2026
phiwuu
left a comment
phiwuu
left a comment
Member
There was a problem hiding this comment.
Please also:
- update the
CHANGELOG.md - add a system test
…d combos - Raise KeyError when baseline_id is combined with import_tagged or numeric import_query (instead of silently ignoring) - Change baseline_id type validation from KeyError to ValueError - Catch KeyError in _run_impl for clean exit code 1 - Remove 'silently ignored' behavioral note from docs - Update CHANGELOG.md with baseline_id feature entry - Add system test for baseline_id validation (test_baseline_id.py) - Extend test runner ConfigFileData with import_tagged and baseline_id
…test
The cbQL query endpoint returns items directly in the 'items' array,
not wrapped in {'item': {...}} like the report-ID endpoint does.
Collaborator
Author
Changelog is updated an a system test was already added |
kedarnn
requested changes
Jun 19, 2026
| completed_process = self._test_runner.run_tool_test() | ||
| asserter = Asserter(self, completed_process, self._test_runner) | ||
| asserter.assertExitCode(1) | ||
| self.assertIn("mutually exclusive", completed_process.stderr) |
Contributor
There was a problem hiding this comment.
Please compare with the full error message like it is done here.
It might happen that two errors might contain same words, so better to assert with full error for correctness.
Address PR review: compare the complete stderr output instead of only a substring (assertIn), since different errors may share the same words.
kedarnn
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.