Skip to content

LOBSTER Report - no schema#524

Open
ThomasDebobenVispiron wants to merge 44 commits into
mainfrom
vtt/lobster_report_v2
Open

LOBSTER Report - no schema#524
ThomasDebobenVispiron wants to merge 44 commits into
mainfrom
vtt/lobster_report_v2

Conversation

@ThomasDebobenVispiron

Copy link
Copy Markdown
Contributor

Remove schema from .lobster files with version 5.
Only write Item's to get remove Requirement, Implementation and Acticity in the future.
For transition period the old versions are still supported.

Introduce new yaml config file for LOBSTER report.

For future use we want to support a yaml file as config file fore the lobster_report tool.
During implementation and testing phase the known .conf file still can be used.
For future use we want to support a yaml file as config file fore the lobster_report tool.
During implementation and testing phase the known .conf file still can be used.
For future use we want to support a yaml file as config file fore the lobster_report tool.
During implementation and testing phase the known .conf file still can be used.
For future use we want to support a more flexible configuration.
Therefor we remove the schema (requrement, implementation, code) from the lobster files. Version without schema is 5.
All items are now from base Item class.

Remove schema from .lobster files with version 5.
Only write Item's to get remove Requirement, Implementation and Acticity in the future.
For transition period the old versions are still supported.
Remove schema from .lobster files with version 5.
Only write Item's to get remove Requirement, Implementation and Acticity in the future.
For transition period the old versions are still supported.
@ThomasDebobenVispiron ThomasDebobenVispiron requested a review from a team as a code owner January 13, 2026 15:08
Remove schema from .lobster files with version 5.
Only write Item's to get remove Requirement, Implementation and Acticity in the future.
For transition period the old versions are still supported.
fix pylint
fix bazel integration

@mugdhadhole1 mugdhadhole1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both old and new code currently run and the old one will be removed later, it will be very helpful if a comment exists marking where the old code exists.

@mugdhadhole1 mugdhadhole1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README to reflect the latest changes in the tools. The example section also needs to be revised to match the updated implementation.

@mugdhadhole1

Copy link
Copy Markdown
Contributor

I'm attaching an example where I attempted to generate the HTML report.
The report generated, but the content was empty.
example.zip

Comment thread tests_system/lobster_html_report/data/octopus_tracing_policy_no_schema.html Outdated
Comment thread tests_integration/projects/basic/report.reference_output.lobster Outdated
Comment thread tests_integration/projects/basic/Makefile
Comment thread data/lobster_ok.yaml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this folder added at root level?

Comment thread documentation/config_files.md Outdated
Comment thread documentation/config_files.md Outdated
Comment thread documentation/config_files.md Outdated
Comment thread documentation/config_files.md Outdated
Comment thread documentation/manual-lobster_cpptest.md Outdated
Comment on lines +81 to +82
The tool supports three configuration attributes:
`output_file`, `codebeamer_url` and `files`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the deprecated functionality the user still need to give kind. So I think over here we need to have documentations for both the usages.

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread data/lobster_ok.yaml Outdated
@@ -0,0 +1,15 @@
Requirements: !LevelDefinition

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any references to this file in tests, docs, or build targets.

Comment thread lobster/common/report.py
Comment thread lobster/common/tracing_policy_schema.yamale
Comment thread tests_unit/test_io.py
def test_lobster_read_missing_versio_key(self, mock_file_open, mock_isfile):
with self.assertRaises(LOBSTER_Error):
lobster_read(self.mh, self.filename, self.level, self.items, self.source_info)
self.mh.error.assert_called_with(ANY, "required top-level key version not present")

@phiwuu phiwuu May 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Method error has no assert_called_with member (no-member)
  • Undefined variable ANY (undefined-variable)

(detected by pylint)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants