Conversation
bmourad01
force-pushed
the
rule-ppx
branch
3 times, most recently
from
July 22, 2026 04:53
46e6845 to
2ceb921
Compare
Similarly, we raise the janestreet version to v0.17
This is a `MonadFail`-style PPX rewriter so that we can write more declarative rewrite/transformation-style rules directly in OCaml. Our first test case is on the x86 peephole rules.
bmourad01
force-pushed
the
rule-ppx
branch
3 times, most recently
from
July 22, 2026 12:45
17b41b7 to
0dd8fbf
Compare
Checking `has_edge` with the representative isn't sufficient
This is the bigger change, and we've adjusted the use of the `Context` monad such that we can avoid all of the intermediate `Some` allocations. Also fixes a few pre-existing miscompiles in x86 isel
This makes a big difference for `clang-format`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.