docs(changelog): add v0.7.0 entry, bump plugin version, fix dead skill path - #31
docs(changelog): add v0.7.0 entry, bump plugin version, fix dead skill path#31bmadcode wants to merge 1 commit into
Conversation
…l path Covers #28, #29, and #30. Marketplace plugin version goes 0.6.0 -> 0.7.0. Also fixes a real defect found while validating: marketplace.json listed ./src/workflows/2-design/gds-create-ux-design, which v0.6.0 replaced with gds-ux, and gds-ux was never added in its place. Anyone installing the plugin got a dead path and no UX skill. All 33 listed paths now resolve.
WalkthroughThe plugin metadata now targets version 0.7.0 and the ChangesPlugin release update
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude-plugin/marketplace.json:
- Line 15: Synchronize the package version with the marketplace metadata: update
the release/versioning flow around package.json.version and the marketplace
version entry so npm version uses the marketplace’s current version as its base
before applying the requested bump, ensuring both remain aligned for publishing.
In `@CHANGELOG.md`:
- Line 10: Update the changelog entry to state that
`.claude-plugin/marketplace.json` omitted the existing `gds-ux` skill entry,
rather than claiming the skill was never added or did not exist; preserve the
explanation that the outdated `gds-create-ux-design` path caused the published
plugin to reference a dead path.
- Line 132: Update the historical changelog note to capitalize “Markdown” in
both occurrences: “Markdown links” and “Markdown-style links,” without changing
the surrounding wording.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a2aa4388-385e-40cb-a6a8-c788ede8dd36
📒 Files selected for processing (2)
.claude-plugin/marketplace.jsonCHANGELOG.md
| "source": "./", | ||
| "description": "A comprehensive game development module with agents and workflows for preproduction, design, architecture, production, and testing across Unity, Unreal, and Godot. Part of the BMad Method ecosystem.", | ||
| "version": "0.6.0", | ||
| "version": "0.7.0", |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' "Declared versions:"
rg -n '"version":' package.json .claude-plugin/marketplace.json
printf '%s\n' "Release automation references:"
fd -H -t f -0 -e yml -e yaml -e json -e js -e ts -e sh |
xargs -0 -r rg -n -C 4 'package\.json|marketplace\.json|npm (version|publish)|0\.7\.0'Repository: bmad-code-org/bmad-module-game-dev-studio
Length of output: 3179
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' "workflow outline:"
ast-grep outline .github/workflows/release.yaml --view expanded || true
printf '%s\n' "release workflow body:"
cat -n .github/workflows/release.yaml | sed -n '1,180p'
printf '%s\n' "workflow dispatch config:"
cat -n .github/workflows/release.yaml | sed -n '1,80p'
printf '%s\n' "other marketplace/version references:"
rg -n 'marketplace\.json|version.*0\.7\.0|npm version|npm publish|sourceless|publish' .github .claude-plugin package.json 2>/dev/null || trueRepository: bmad-code-org/bmad-module-game-dev-studio
Length of output: 7829
Synchronize the version in package.json with the marketplace metadata.
.claude-plugin/marketplace.json declares 0.7.0, while package.json still has 0.6.0. npm version ${{ inputs.bump }} bumps package.json by patch/minor/major instead of setting the marketplace version, so publish will use 0.8.0 for the next patch release. Set or automate package.json.version to match the marketplace entry before release.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude-plugin/marketplace.json at line 15, Synchronize the package version
with the marketplace metadata: update the release/versioning flow around
package.json.version and the marketplace version entry so npm version uses the
marketplace’s current version as its base before applying the requested bump,
ensuring both remain aligned for publishing.
| - **All Python invocations go through `uv run`** (#30). Sixty-one call sites shelled out to a bare `python3` to run `_bmad/scripts/resolve_customization.py`, plus one for `render-validation-html.py`. The resolver declares `requires-python = ">=3.11"` and hard-exits below it, because `tomllib` is a 3.11 stdlib addition. On macOS without Homebrew or Ubuntu 22.04, where `python3` is 3.10, activation fell through to the "if the script fails" path and hand-merged the TOML layers in-context — no error surfaced. `uv run` reads each script's own `requires-python` and provisions a matching interpreter. | ||
| - **Browser openers no longer spawn a Python interpreter** (#30). Four sites ran `python3 -c "import webbrowser, pathlib; webbrowser.open(...)"` purely to open an HTML file. They now use the platform opener — `open` on macOS, `xdg-open` on Linux, `start ""` on Windows — and hand you the file path if that fails instead of leaving you waiting on a window that never appears. These were the last place the module needed a system Python at all, and they failed silently on a machine that has none. | ||
| - **README Python badge corrected to `>=3.11`** (#30). It advertised `>=3.10`, a floor that cannot run the shared resolver. | ||
| - **The published plugin pointed at a skill that doesn't exist.** `.claude-plugin/marketplace.json` still listed `gds-create-ux-design`, which v0.6.0 replaced with `gds-ux` — and `gds-ux` itself was never added. Anyone installing the plugin got a dead path and no UX skill. Swapped; all 33 listed paths now resolve. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Describe the marketplace omission accurately.
src/workflows/2-design/gds-ux/SKILL.md Lines 1-6 and src/agents/gds-agent-game-designer/customize.toml Lines 51-59 show that gds-ux exists. The missing entry was in .claude-plugin/marketplace.json, not the skill itself.
Proposed wording
-which v0.6.0 replaced with `gds-ux` — and `gds-ux` itself was never added.
+which v0.6.0 replaced with `gds-ux` — but `gds-ux` was not added to the marketplace skill list.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - **The published plugin pointed at a skill that doesn't exist.** `.claude-plugin/marketplace.json` still listed `gds-create-ux-design`, which v0.6.0 replaced with `gds-ux` — and `gds-ux` itself was never added. Anyone installing the plugin got a dead path and no UX skill. Swapped; all 33 listed paths now resolve. | |
| - **The published plugin pointed at a skill that doesn't exist.** `.claude-plugin/marketplace.json` still listed `gds-create-ux-design`, which v0.6.0 replaced with `gds-ux` — but `gds-ux` was not added to the marketplace skill list. Anyone installing the plugin got a dead path and no UX skill. Swapped; all 33 listed paths now resolve. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` at line 10, Update the changelog entry to state that
`.claude-plugin/marketplace.json` omitted the existing `gds-ux` skill entry,
rather than claiming the skill was never added or did not exist; preserve the
explanation that the outdated `gds-create-ux-design` path caused the published
plugin to reference a dead path.
| ### Opencode Compatibility Fix | ||
|
|
||
| * Changed SKILL.md workflow references from markdown links (`[workflow.md](workflow.md)`) to bare paths (`./workflow.md`) across all 28 workflow skills, matching the BMAD-METHOD convention. Opencode does not follow markdown-style links when resolving skill workflow files. | ||
| - Changed SKILL.md workflow references from markdown links (`[workflow.md](workflow.md)`) to bare paths (`./workflow.md`) across all 28 workflow skills, matching the BMAD-METHOD convention. Opencode does not follow markdown-style links when resolving skill workflow files. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Capitalize Markdown in the historical note.
Use Markdown in both Markdown links and Markdown-style links at Line 132.
Proposed wording
-Changed SKILL.md workflow references from markdown links (`[workflow.md](workflow.md)`) to bare paths (`./workflow.md`) across all 28 workflow skills, matching the BMAD-METHOD convention. Opencode does not follow markdown-style links when resolving skill workflow files.
+Changed SKILL.md workflow references from Markdown links (`[workflow.md](workflow.md)`) to bare paths (`./workflow.md`) across all 28 workflow skills, matching the BMAD-METHOD convention. Opencode does not follow Markdown-style links when resolving skill workflow files.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Changed SKILL.md workflow references from markdown links (`[workflow.md](workflow.md)`) to bare paths (`./workflow.md`) across all 28 workflow skills, matching the BMAD-METHOD convention. Opencode does not follow markdown-style links when resolving skill workflow files. | |
| - Changed SKILL.md workflow references from Markdown links (`[workflow.md](workflow.md)`) to bare paths (`./workflow.md`) across all 28 workflow skills, matching the BMAD-METHOD convention. Opencode does not follow Markdown-style links when resolving skill workflow files. |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~132-~132: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...anged SKILL.md workflow references from markdown links ([workflow.md](workflow.md)) to...
(MARKDOWN_NNP)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` at line 132, Update the historical changelog note to capitalize
“Markdown” in both occurrences: “Markdown links” and “Markdown-style links,”
without changing the surrounding wording.
Source: Linters/SAST tools
1 participant
Release notes for v0.7.0, covering #28, #29, and #30 — plus a real defect found while validating.
.claude-plugin/marketplace.jsonlisted:That directory was removed in v0.6.0, which replaced it with
gds-ux— andgds-uxwas never added to the plugin. So anyone installing the game-dev-studio plugin got a dead path and no UX skill at all, while the v0.6.0 changelog announced the new skill.Swapped. I then checked the whole array both directions: all 33 listed paths resolve, and no real skill is unlisted.
Changelog
The v0.7.0 entry covers:
resolve_customization.pyinvocations plus onerender-validation-html.pymoved touv run; the fourpython3 -c "import webbrowser…"browser openers replaced with the platform opener; README badge>=3.10→>=3.11Version bump
Marketplace plugin
0.6.0→0.7.0.package.jsonis left alone; the release workflow owns it.Nothing in
publish.yamltouchesmarketplace.json, so it drifts unless bumped by hand — which is also how the deadgds-create-ux-designpath survived a full release. bmad-method-test-architecture-enterprise solves this with aSync marketplace versionstep plus atest-release-metadata.jsguard; worth copying here, ideally extended to assert every skill path resolves.Verification
markdownlint and prettier pass.
Summary by CodeRabbit
New Features
uv run.Documentation