-
Notifications
You must be signed in to change notification settings - Fork 38
fix(tui): resolve a run's control window by identity, not listing order #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pbean
merged 22 commits into
bmad-code-org:main
from
dracic:fix/482-ctl-window-identity
Aug 11, 2026
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9142677
fix(tui): resolve a run's control window by identity, not listing order
dracic cc26fb8
fix(tui): harden the ctl-window record's failure paths
dracic 251f77e
fix(tui): address review — trim the #482 changelog entry, drop a usel…
dracic 50bab0e
fix(tui): survive a non-OSError from the ctl-window record write
d31f08b
fix(tui): refuse a symlinked ctl-window record instead of writing thr…
d5acf47
fix(tui): replace the ctl-window record's name, never a link's target
d203f4e
fix(tui): bound and shape-check the ctl-window record read
c2fdffe
fix(tui): prove the ctl-window record against the live listing
b2a0b81
fix(tui): scope the ctl-window lookup to its project
bd64a93
test(tui): pin tmux in the resolve record-warning test
f1c60e1
fix(tui): confine the record path and prefer tagged windows
ae67ea4
fix(platform): inherit nothing when replacing a name no-follow
7ecb190
fix(tui): match the whole run id when resolving a control window
385fa22
fix(tui): anchor the ctl-window record write at a directory descriptor
80ae01e
fix(tui): anchor the ctl-window record removal at a directory descriptor
4f084c5
fix(tui): see junctions when checking that a run dir is confined
899d81a
fix(tui): forget the previous record when recording is skipped
c251c20
fix(mux): keep delimiters out of the project-tag comparison
597631c
fix(mux): reject every line separator in a project tag, not just LF
fdbb684
fix(mux): encode a project tag the listing cannot carry
f765f9e
chore: hoist _TMP_NAME_ATTEMPTS and drop a stray paren
2cfd10a
fix(mux): encode a filename byte the listing cannot decode either
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.