Skip to content

fix(skills): CodeQL code-quality — missing comma, empty except, unused import #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
risleylima wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(skills): CodeQL code-quality — missing comma, empty except, unused import #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skills/bmad-agent-builder/assets/init-sanctum-template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def generate_capabilities_md(capabilities: list[dict], evolvable: bool) -> str:
"",
"## Tools",
"",
"Prefer crafting your own tools over depending on external ones. A script you wrote "
"Prefer crafting your own tools over depending on external ones. A script you wrote ",

@coderabbitai coderabbitai Bot Aug 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Keep the Tools guidance as one generated line.

The comma on Line 170 makes Line 171 a separate lines element. "\n".join(lines) inserts a newline between wrote and and saved, which changes the generated CAPABILITIES.md content.

Keep both fragments in one list element while avoiding implicit string concatenation.

Proposed fix 
-        "Prefer crafting your own tools over depending on external ones. A script you wrote ",
-        "and saved is more reliable than an external API. Use the file system creatively.",
+        (
+            "Prefer crafting your own tools over depending on external ones. "
+            + "A script you wrote and saved is more reliable than an external API. "
+            + "Use the file system creatively."
+        ),
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Prefer crafting your own tools over depending on external ones. A script you wrote ",
(
"Prefer crafting your own tools over depending on external ones. "
"A script you wrote and saved is more reliable than an external API. "
"Use the file system creatively."
),
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/bmad-agent-builder/assets/init-sanctum-template.py` at line 170,
Update the Tools guidance entries in the generated lines list so the fragments
ending with “wrote” and beginning with “and saved” remain one list element
without relying on implicit string concatenation. Preserve the resulting
single-line output when "\n".join(lines) generates CAPABILITIES.md.

"and saved is more reliable than an external API. Use the file system creatively.",
"",
"### User-Provided Tools",
Expand Down
1 change: 1 addition & 0 deletions skills/bmad-agent-builder/scripts/render_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ def atomic_write(path: Path, text: str) -> None:
try:
os.unlink(tmp)
except OSError:
# Best-effort temp cleanup; original error must still propagate.
pass
raise

Expand Down
1 change: 1 addition & 0 deletions skills/bmad-module-builder/scripts/scaffold-standalone-module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ def main() -> int:
elif stripped.startswith("module_version:"):
module_version = stripped.split(":", 1)[1].strip().strip('"').strip("'")
except Exception:
# Optional metadata — keep marketplace defaults when module.yaml is missing/unreadable.
pass

skill_dir_name = skill_dir.name
Expand Down
1 change: 1 addition & 0 deletions skills/bmad-workflow-builder/scripts/render_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ def atomic_write(path: Path, text: str) -> None:
try:
os.unlink(tmp)
except OSError:
# Best-effort temp cleanup; original error must still propagate.
pass
raise

Expand Down
1 change: 0 additions & 1 deletion skills/bmad-workflow-builder/scripts/tests/test_canon_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
Run with: python3 -m pytest test_canon_sync.py
(or plain `python3 test_canon_sync.py` for a lightweight self-check).
"""
import sys
from pathlib import Path

SKILLS_DIR = Path(__file__).resolve().parents[3]
Expand Down