fix: bump eval fixture vitest past the CVE-2026-47429 range - #2686
fix: bump eval fixture vitest past the CVE-2026-47429 range#2686tjoignant wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe three ChangesVitest fixture updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryUpdates the Vitest development-dependency constraint from
Confidence Score: 5/5The PR appears safe to merge because the dependency changes occur only in static eval inputs and do not alter an installed or executed dependency path. The evaluation flow reads these manifests as project context and checks the Vitest command or framework identity rather than resolving or executing the declared version, so the three version updates preserve existing behavior.
|
| Filename | Overview |
|---|---|
| src/bmm-skills/plan/bmad-project-context/evals/files/fixture-brownfield/package.json | Safely updates the inert brownfield fixture’s Vitest constraint without affecting its evaluation contract. |
| src/bmm-skills/plan/bmad-project-context/evals/files/fixture-refresh/package.json | Safely updates the inert refresh fixture’s Vitest constraint beyond the vulnerable range. |
| src/bmm-skills/plan/bmad-project-context/evals/files/fixture-standalone/package.json | Safely updates the inert standalone fixture’s Vitest constraint beyond the vulnerable range. |
Reviews (1): Last reviewed commit: "fix: bump eval fixture vitest past the C..." | Re-trigger Greptile
What
Bumps the
vitestpin from^1.6.0to^3.2.6in the threebmad-project-contexteval fixtures (fixture-standalone,fixture-refresh,fixture-brownfield).Why
vitest < 3.2.6carries CVE-2026-47429 (critical, arbitrary file read/execute via the Vitest UI server). The fixtures are inert eval inputs and are never installed, so there is no real exposure — but GitHubs dependency graph parses everypackage.jsonon the default branch. In any repo that installs BMad into.claude/skills/, these three files show up as three open critical Dependabot alerts, sitting on top of that repos genuine findings.Downstream cannot fix this locally:
.claude/skills/is installer-managed, so a hand-bumped pin is overwritten on the nextbmmrefresh. I bumped it twice in my own repo and the installer reverted it both times.How
^3.2.6rather than^4.x— the minimum that clears the advisory, and it keeps the wavecart fixtures slightly-behind-a-real-project character.fixture-brownfieldis deliberately left alone.Testing
evals/cases.jsonasserts on the test command (vitest), never a version, so no expectation changes. Grepped the eval tree to confirm1.6appears nowhere else.