Skip to content

docs(core): include deep-recon in core skill count references - #2626

Open
santhiprakash wants to merge 1 commit into
bmad-code-org:mainfrom
santhiprakash:fix/core-tools-count
Open

docs(core): include deep-recon in core skill count references#2626
santhiprakash wants to merge 1 commit into
bmad-code-org:mainfrom
santhiprakash:fix/core-tools-count

Conversation

@santhiprakash

Copy link
Copy Markdown

What

Sync the English core-tools and commands reference pages with the shipped core skill set so bmad-deep-recon is counted and listed.

Why

src/core-skills/bmad-deep-recon exists, but docs/reference/core-tools.md says the module has "seven core skills" with three thinking skills, and docs/reference/commands.md says "8 built-in tools" while only naming seven. Both summaries omit deep-recon.

How

  • core-tools.md: update the intro to "eight core skills" / "four thinking skills" and add deep-recon to the thinking-skills list.
  • commands.md: add deep-recon to the parenthetical list of thinking skills.

Testing

  • git show upstream/main:<file> confirmed the bug marker is still present.
  • python3 ../scripts/preflight_ship.py passed (no open duplicates, fix marker absent).
  • node tools/validate-file-refs.js --strict → 0 broken refs.
  • node tools/validate-doc-links.js, node tools/validate-sidebar-order.js, node tools/build-docs.mjs, and node tools/validate-skills.js --strict all passed.

- Problem: docs/reference/core-tools.md and commands.md still describe the core module as 7/8 skills but omit bmad-deep-recon from the summary list, even though src/core-skills/bmad-deep-recon is a shipped core skill.

- Fix: update both summaries to four thinking skills and include deep-recon.

- Verification: re-read upstream/main, ran tools/validate-file-refs.js --strict (0 broken refs), preflight_ship.py (clear), node tools/validate-doc-links.js, node tools/validate-sidebar-order.js, node tools/build-docs.mjs, and node tools/validate-skills.js --strict.
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 76e8f358-16c1-484e-8538-6d0fb9286beb

📥 Commits

Reviewing files that changed from the base of the PR and between bb45db4 and 215c1c7.

📒 Files selected for processing (2)
  • docs/reference/commands.md
  • docs/reference/core-tools.md

📝 Walkthrough

Walkthrough

The documentation now describes the core module as providing eight skills, including deep-recon, and updates the related built-in tools reference.

Changes

Core skills documentation

Layer / File(s) Summary
Core skills reference alignment
docs/reference/core-tools.md, docs/reference/commands.md
Updates the core skill count from seven to eight, adds deep-recon to the listed thinking skills, and aligns the built-in tools description with the Core Tools reference.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bmadcode

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the doc update about adding deep-recon to core skill references.
Description check ✅ Passed The description directly explains the documentation changes and why they were needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant