Skip to content

fix(silo): read ids from Silo's catalog cards and show why Silo refused a request - #54

Merged
blurbery merged 2 commits into
mainfrom
fix/silo-api-v2
Nov 18, 2026
Merged

blurbery merged 2 commits into
mainfrom
fix/silo-api-v2

Conversation

@blurbery

Copy link
Copy Markdown
Owner

What this changes

I audited CineSets against Silo's current v2 API (upstream main at 83b40ad, 17 November) and against the newest Emby and Jellyfin releases. Nothing is broken: CineSets makes no /api/v1 calls anywhere (v1 was retired in Silo-Server/silo-server#3200), and every route, parameter and field it uses on Silo, Emby and Jellyfin still matches. The weekly newest-servers run on 16 November passed on Silo build 2488, Jellyfin 12.4, Emby 4.10.2.0 and Emby 4.11 beta. This PR picks up what has changed since:

  • Ids from Silo's catalog cards. Since feat(catalog): include IMDb, TMDB and TVDB IDs on catalog cards Silo-Server/silo-server#3618 (6 November), /api/v2/catalog cards carry the title's tmdb_id, imdb_id and tvdb_id, the same ones item detail gives. The index now reads them from the card. Shows whose card has ids skip the per-show /catalog/items/{id} lookup, and a film Silo knows by its IMDb id (movie-imdb-…) now also matches lists by its TMDB id. Silo builds without ids on their cards are looked up exactly as before.
  • Silo's reason for a refused request. Silo puts the reason for a refused field in errors[].detail, and CineSets only showed detail, which says "see errors". Since fix(collections): refuse a taken collection name instead of failing with a 500 Silo-Server/silo-server#3933 (14 November), Silo refuses a collection name another collection in the library already has, ignoring case and spacing. The error now shows Silo's own reason.
  • Collection a section still uses. Deleting a collection that a Home or library section shows gets a 409 from Silo. The error now says to take it out of that section first.
  • CI pins. Silo build-1144 (7 October, from before v1 was retired) moves to build-2519 (17 November), Jellyfin 12.2 to 12.4, and Emby 4.10.1.0 to 4.10.2.0. The setup docs list 12.4.

Not changed, but worth knowing:

  • CineSets' own duplicate-name check still compares names exactly, so it leaves the near-duplicate case to Silo's (now readable) refusal. Making it ignore case would also change behaviour on Emby and Jellyfin, which allow those names.
  • Jellyfin 13 is expected to remove legacy auth and the deprecated /Startup routes the end-to-end script uses. CineSets already authenticates with the Authorization header that 12.x needs, so only the test script will need changes then.

How I tested it

  • pytest tests/test_silo.py tests/test_engine.py tests/test_catalog_config.py: 142 passed (Python 3.14).
  • New tests in tests/test_silo.py:
    • test_newer_silo_gives_the_ids_on_its_cards turns on ids on the fake Silo's cards and checks no show is looked up, every id matches, and a film known by its IMDb id matches by TMDB.
    • test_silo_says_why_it_refused checks the errors[].detail reason and the 409 section hint show, and that other 409s are left alone.
    • Both fail on main and pass with this change. The existing test_show_ids_are_looked_up_once still covers older builds.
  • ruff check cinesets tests: clean.
  • The end-to-end jobs on this PR run CineSets against Silo build 2519, Jellyfin 10.10, 10.11 and 12.4, and Emby 4.9 and 4.10.2.0.

Release notes

BEGIN_COMMIT_OVERRIDE
fix(silo): show Silo's reason when it refuses a collection name, and what to do when a section still uses a collection
perf(silo): read show and film ids from Silo's catalog cards instead of looking each show up
ci: test against Silo build 2519, Jellyfin 12.4 and Emby 4.10.2.0
END_COMMIT_OVERRIDE

AI disclosure (required)

  • No AI tools were used for any part of this change.
  • AI tools were used for this change, as described below.

AI tools used and what they did:

I designed and directed this change (an audit of every Silo, Emby and Jellyfin call against the current APIs, reading ids from Silo's cards with a fallback for older builds, surfacing Silo's own reasons rather than loosening CineSets' name check, and moving the CI pins) and used Claude Opus to help write the code, tests and this description, and to run the API audit.

Checklist

  • I've read CONTRIBUTING.md.
  • The title follows Conventional Commits, like fix: keep posters on Jellyfin 12.
  • I understand every line of this change and can explain it.
  • New source files have the CineSets header, and the unit tests pass.
  • Nothing private is included (server addresses, API keys, user names, logs).

…ed a request

Silo's v2 catalog cards carry the title's TMDB, IMDb and TVDB ids since Silo-Server/silo-server#3618, so shows no longer need a detail lookup each and a film Silo knows by its IMDb id matches by its TMDB id too. Builds without ids on their cards are looked up as before.

Silo puts the reason for a refused field in errors[].detail, which CineSets dropped, so a collection name another one in the library already has (Silo-Server/silo-server#3933, case aside) only said "see errors". Those reasons now show, and a collection a Home or library section still uses says to take it out of the section first.

CI now runs against Silo build 2519 (was 1144, from before /api/v1 was retired), Jellyfin 12.4 and Emby 4.10.2.0.
@github-actions

Copy link
Copy Markdown
Contributor

Reviewed the diff and found nothing that needs fixing.

@blurbery
blurbery merged commit db4cf8a into main Nov 18, 2026
17 checks passed
@blurbery
blurbery deleted the fix/silo-api-v2 branch November 18, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant