Repository navigation
fix(silo): read ids from Silo's catalog cards and show why Silo refused a request - #54
Merged
Merged
Conversation
…ed a request Silo's v2 catalog cards carry the title's TMDB, IMDb and TVDB ids since Silo-Server/silo-server#3618, so shows no longer need a detail lookup each and a film Silo knows by its IMDb id matches by its TMDB id too. Builds without ids on their cards are looked up as before. Silo puts the reason for a refused field in errors[].detail, which CineSets dropped, so a collection name another one in the library already has (Silo-Server/silo-server#3933, case aside) only said "see errors". Those reasons now show, and a collection a Home or library section still uses says to take it out of the section first. CI now runs against Silo build 2519 (was 1144, from before /api/v1 was retired), Jellyfin 12.4 and Emby 4.10.2.0.
Contributor
|
Reviewed the diff and found nothing that needs fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
I audited CineSets against Silo's current v2 API (upstream
mainat83b40ad, 17 November) and against the newest Emby and Jellyfin releases. Nothing is broken: CineSets makes no/api/v1calls anywhere (v1 was retired in Silo-Server/silo-server#3200), and every route, parameter and field it uses on Silo, Emby and Jellyfin still matches. The weekly newest-servers run on 16 November passed on Silo build 2488, Jellyfin 12.4, Emby 4.10.2.0 and Emby 4.11 beta. This PR picks up what has changed since:/api/v2/catalogcards carry the title'stmdb_id,imdb_idandtvdb_id, the same ones item detail gives. The index now reads them from the card. Shows whose card has ids skip the per-show/catalog/items/{id}lookup, and a film Silo knows by its IMDb id (movie-imdb-…) now also matches lists by its TMDB id. Silo builds without ids on their cards are looked up exactly as before.errors[].detail, and CineSets only showeddetail, which says "see errors". Since fix(collections): refuse a taken collection name instead of failing with a 500 Silo-Server/silo-server#3933 (14 November), Silo refuses a collection name another collection in the library already has, ignoring case and spacing. The error now shows Silo's own reason.build-1144(7 October, from before v1 was retired) moves tobuild-2519(17 November), Jellyfin12.2to12.4, and Emby4.10.1.0to4.10.2.0. The setup docs list 12.4.Not changed, but worth knowing:
/Startuproutes the end-to-end script uses. CineSets already authenticates with theAuthorizationheader that 12.x needs, so only the test script will need changes then.How I tested it
pytest tests/test_silo.py tests/test_engine.py tests/test_catalog_config.py: 142 passed (Python 3.14).tests/test_silo.py:test_newer_silo_gives_the_ids_on_its_cardsturns on ids on the fake Silo's cards and checks no show is looked up, every id matches, and a film known by its IMDb id matches by TMDB.test_silo_says_why_it_refusedchecks theerrors[].detailreason and the 409 section hint show, and that other 409s are left alone.mainand pass with this change. The existingtest_show_ids_are_looked_up_oncestill covers older builds.ruff check cinesets tests: clean.Release notes
AI disclosure (required)
AI tools used and what they did:
I designed and directed this change (an audit of every Silo, Emby and Jellyfin call against the current APIs, reading ids from Silo's cards with a fallback for older builds, surfacing Silo's own reasons rather than loosening CineSets' name check, and moving the CI pins) and used Claude Opus to help write the code, tests and this description, and to run the API audit.
Checklist
fix: keep posters on Jellyfin 12.