Repository navigation
feat(notifications): add in-app notifications foundation - #537
Draft
solarisael wants to merge 2 commits into
Draft
solarisael wants to merge 2 commits into
solarisael wants to merge 2 commits into
Conversation
Signed-off-by: solarisael <alvorada.zicari@gmail.com>
Signed-off-by: solarisael <alvorada.zicari@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
in progress!
foundation for in-app notifications.
public.notify()is the only thing that writes them, and it runs inside the event's own transaction... so adding a type is a registry row, anotify()call where the event happens, and a renderer in the app.two types wired to start: guide review decision and upvotes (grouped per guide). bell dropdown and
/settings/notificationsfollow the mockups, and the types that don't send yet show up disabled.will structure this properly as it fills in!
Closes #531
Type of change
Verification
pnpm -r typecheckpassespnpm -r buildpasses