fix: route 5 GiB uploads through multipart upload#42
Merged
Conversation
panagpapad
force-pushed
the
fix/mongo-exporter-multipart-at-5gb
branch
from
a40cde9 to
213b621
Compare
* The size check used `>`, causing files exactly 5 GiB to be uploaded via `PutObject`, which exceeds S3's single-request upload limit. * Change the threshold check to `>=` so 5 GiB exports use multipart upload instead. * Extract `GiB` and `S3_PUT_OBJECT_MAX_SIZE` into named constants.
panagpapad
force-pushed
the
fix/mongo-exporter-multipart-at-5gb
branch
from
213b621 to
79e1dae
Compare
pavlospt
approved these changes
Jun 23, 2026
panagpapad
force-pushed
the
fix/mongo-exporter-multipart-at-5gb
branch
from
443e7b7 to
61c316f
Compare
Single read() calls returned OS-sized chunks (~2 MiB) instead of filling the 1 GiB part buffer, producing thousands of parts below S3's 5 MiB minimum and causing EntityTooSmall on CompleteMultipartUpload.
panagpapad
force-pushed
the
fix/mongo-exporter-multipart-at-5gb
branch
from
61c316f to
0d2e501
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
>, causing files exactly 5 GiB to be uploaded viaPutObject, which exceeds S3's single-request upload limit.>=so 5 GiB exports use multipart upload instead.GiBandS3_PUT_OBJECT_MAX_SIZEinto named constants.