fix(scripts): make all scripts executable before running scripts #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmpinder
previously approved these changes
Dec 30, 2025
If scripts are only made executable right before they run, then a script that attempts to call a script later in the list will fail because that script won't be executable yet. Instead, make all files in the scripts directory executable first, then run the scripts in order.
HastD
force-pushed
the
script-chmod-fix
branch
from
b495fdd to
3049d08
Compare
Contributor
Author
|
I just realized my initial PR wouldn't work properly, since it would only make the scripts executable that were included in that particular invocation of the scripts module, so it wouldn't cover scripts in the scripts directory that aren't on that list (such as auxiliary scripts meant to be invoked with arguments by another script, not directly by the scripts module). I've changed it to simply match the behavior of v1 of the scripts module and make all files in the scripts directory executable. |
gmpinder
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If scripts are only made executable right before they run, then a script that attempts to call a script later in the list will fail because that script won't be executable yet. Instead, make all files in the scripts directory executable first, then run the scripts in order.