Match bb definitions #5684
Open
Match bb definitions #5684
+17
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chands10
force-pushed
the
h
branch
3 times, most recently
from
f98bcfb to
7832f20
Compare
roborivers
suggested changes
Jan 22, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
chands10
commented
Jan 22, 2026
| sqlquery.bindvars = bindvars; | ||
| sqlquery.n_types = ntypes; | ||
| sqlquery.types = types; | ||
| sqlquery.types = (int *)types; // TODO: Is this ok? bb is able to assign without casting |
Contributor
Author
There was a problem hiding this comment.
types is const int *, sqlquery.types is expecting int *
Contributor
Author
There was a problem hiding this comment.
Getting error in open trying to compile without casting, warning in bb but we ignore
roborivers
approved these changes
Jan 22, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
insert_lots
incoh_remsql
incoh_remsql_rte_connect_generated
chands10
commented
Jan 27, 2026
| int retries_done, int do_append, int fromline) | ||
| static int cdb2_send_query(cdb2_hndl_tp *hndl, cdb2_hndl_tp *event_hndl, SBUF2 *sb, const char *dbname, const char *sql, | ||
| int n_set_commands, int n_set_commands_sent, char **set_commands, int n_bindvars, | ||
| CDB2SQLQUERY__Bindvalue **bindvars, int ntypes, const int *types, int is_begin, |
Contributor
Author
There was a problem hiding this comment.
(make types const)
Contributor
Author
|
cdb2test Jan 22 13:01:50 2026 success h.R20260122.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us review your pull request, please consider providing an overview of the following: