-
Notifications
You must be signed in to change notification settings - Fork 232
{182135998} force fetching blobs if there are check_constraints #5671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_downgrade
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
389e425 to
b4ce791
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill_logput_window_generated
insert_lots_ssl_generated
insert_lots
ddaa8fd to
d12e2b7
Compare
db/record.c
Outdated
| blobnums[i] = i; | ||
| } | ||
|
|
||
| rc = ix_find_blobs_by_rrn_and_genid_tran(iq, trans, rrn, vgenid, numblobs, blobnums, blobsizes, bloboffs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be optimized to fetch only the missing blobs?
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
jsonify
consumer_non_atomic_default_consumer_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
2383557 to
b41af60
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_downgrade [setup failure]
sc_redo [core dumped]
logfill
jsonify
consumer_non_atomic_default_consumer_generated
insert_lots_ssl_generated
insert_lots
|
/adhoc-test jsonify |
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
jsonify
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
…ptimization) Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.com>
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
bf: force fetching blobs if there are check_constraints (bypass updCols optimization)