Fix & Modernize CI: upgrade to RabbitMQ 4.3.0 and bump other deps#114
Merged
Conversation
|
FWIW the latest RabbitMQ release is |
Contributor
Author
Thanks, that's a good point. I'd agree there's no reason no to use the latest of |
2308d0f to
acda40c
Compare
899bed5 to
e8650ca
Compare
090012a to
137da6d
Compare
michalovits
approved these changes
May 22, 2026
Integration Dockerfile: - Upgrade from rabbitmq:3.7.28 (EOL) to 4.3.0 - Replace python3.8 (EOL) with system python3 - Use apt python3-pip instead of curl get-pip.py (fixes PyYAML build) - Combine apt-get update and install into single RUN layer - Enable RabbitMQ file logging (4.x defaults to console-only in Docker) - Disable rabbitmq_prometheus plugin (port conflict with multi-node tests) - Set NODE_OPTIONS=--dns-result-order=ipv4first (Node 17+ IPv6 fix) Build system (Conan 1 to Conan 2): - Use CMakeDeps + CMakeToolchain generators instead of cmake generator - Replace conanbuildinfo.cmake/conan_basic_setup() with find_package() - Link explicit Boost component targets instead of CONAN_LIBS - Simplify bootstrap script (Conan 2 profile handles compiler settings) - Pass CMAKE_TOOLCHAIN_FILE to cmake via Makefile - Default CMAKE_BUILD_TYPE to Release for Conan 2 toolchain - Remove CONAN_BIN_DIRS workaround in authproto (fixed in Conan 2) Acceptance tests: - Replace python3.8 with python3 throughout - Use RABBITMQ_NODENAME=<name>@localhost for predictable log filenames - Create /tmp/logs before starting RabbitMQ (4.x doesn't auto-create) - Set RABBITMQ_LOGS explicitly (4.x requires it for file logging) - Update amqplib/amqp-connection-manager (frame_max >= 8192 for RabbitMQ 4.x) CI workflow: - Replace turtlebrowser/get-conan with setup-python + pip install conan - Update actions/checkout from v2 to v4
michalovits
approved these changes
May 22, 2026
Contributor
Author
|
@michaelklishin - I used |
michalovits
pushed a commit
that referenced
this pull request
May 28, 2026
Restore `set(Protobuf_USE_STATIC_LIBS ON)` in authproto/CMakeLists.txt. This was inadvertently removed in PR #114 when modernising the find_package call. Without it, protobuf is linked dynamically, causing runtime failures on systems without the shared library installed. Also pre-build the Rust performance tester binary in the integration Dockerfile and require the PERF_TESTER_BIN environment variable in integration-tests.py. This avoids needing a full Rust toolchain in the test runtime environment and gives explicit control over the binary being tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When raising #113, I realised we needed to do some CI updates to get the tests passing again and generally modernise some of the testing dependencies.
Integration Dockerfile:
Build system (Conan 1 to Conan 2):
Acceptance tests:
CI workflow: