Replace embedded source code with global lookup table#22
Draft
Replace embedded source code with global lookup table#22
Conversation
- Add global source map storage (Sk.sourceMaps) - Register source code during compilation instead of embedding - Update annotateSource to not embed source in generated JS - Modify handleTraceback to lookup source from source map - Remove $currSource variable from generated code - Update all suspension handling to not pass source - Tests still pass (553/563) Co-authored-by: acbart <897227+acbart@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix embedding of source code in JavaScript
Replace embedded source code with global lookup table
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler was embedding Python source code directly into generated JavaScript via
$currSourcevariable assignments, bloating output size linearly with program length.Changes
Source storage (
src/misceval.js):Sk.sourceMapsglobal registry indexed by filenameSk.registerSourceMap(filename, source)to store source during compilationSk.getSourceLine(filename, lineno)for runtime lookupCode generation (
src/compile.js):$currSourcevariable declarations and assignments from all generated codeannotateSource()to emit only position info (line/column)$saveSuspensionsignature to remove source parameterSk.compile()to register source in global map instead of passing to compilerError handling (
src/misceval.js):handleTraceback()to lookup source using filename + line numberinjectSusp()Before/After
Before:
After:
Error tracebacks continue to display source correctly via runtime lookup.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.