Solucion a la práxis de CSS, ojo icono spotify - #3
Open
BlockXavi wants to merge 2 commits into
Open
Conversation
alexmf91
reviewed
Oct 23, 2023
| <header> | ||
| <img src="/practica-html-css/src/images/spotify-logo.png" alt="Spotify-logo"/> | ||
| <ul> | ||
| <a href="#">Premium</a> |
Contributor
There was a problem hiding this comment.
Te faltaria poner un elemento html li antes del a
| <main> | ||
|
|
||
| <section class="section-foto"> | ||
| <h1>Music for everyone.</h1> |
Contributor
There was a problem hiding this comment.
Recuerda que de H1 deberia solo haber 1 por pagina, revisa la jerarquia de los encabezados
| </section> | ||
|
|
||
| <section class="section-verde"> | ||
| <ul> |
Contributor
There was a problem hiding this comment.
Si es un elemento que tenga que ser una lista, faltaria el li
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Le he intentado dar una estructura responsiva a base de vh y vw. No he podido fijar la posición absoluta del icono de spotify, aunque he intentado acercarme (bastante centrado)...