Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
HyperIndex uses PascalCase table names and camelCase column names. The casing: "snake_case" option was overriding the explicit column name strings in the schema, causing all table names to be lowercased (e.g. "ProposalOnchain" -> "proposal_onchain"). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29c6f849f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "Transfer", | ||
| (drizzle) => ({ |
There was a problem hiding this comment.
Keep transaction aggregate SQL aligned with renamed tables
Renaming these tables/columns to quoted CamelCase breaks the raw SQL in apps/api/src/repositories/transactions/index.ts: getFilteredAggregateTransactions and filterToSql still reference legacy identifiers like transaction_hash, from_address, transfers.is_dex, and delegations.delegated_value. With this schema change, /transactions queries will hit undefined relation/column errors unless the SQL fragments are migrated to the new names (or compatibility views are added).
Useful? React with 👍 / 👎.
| export const votesOnchain = pgTable("VoteOnchain", (drizzle) => ({ | ||
| id: drizzle.text().primaryKey(), | ||
| txHash: drizzle.text("txHash").notNull(), | ||
| daoId: drizzle.text("daoId").notNull(), | ||
| voterAccountId: drizzle.text("voterAccountId").$type<Address>().notNull(), |
There was a problem hiding this comment.
Keep proposals activity SQL aligned with renamed on-chain tables
These renames are incompatible with apps/api/src/repositories/proposals-activity/index.ts, which still executes raw SQL against proposals_onchain/votes_onchain and snake_case columns (dao_id, tx_hash, voter_account_id, etc.) in getProposals, getUserVotes, and the paginated proposals query. After this commit, proposal-activity endpoints will fail against the new schema.
Useful? React with 👍 / 👎.
| export const daoMetricsDayBucket = pgTable( | ||
| "dao_metrics_day_buckets", | ||
| "DaoMetricsDayBucket", | ||
| (drizzle) => ({ |
There was a problem hiding this comment.
Keep DAO stats SQL aligned with renamed metrics/power tables
Changing this table naming/casing introduces runtime mismatches in apps/api/src/repositories/drizzle/index.ts, where comparison methods still query old identifiers such as dao_metrics_day_buckets, "account_power", "proposals_onchain", and "votes_onchain". Those dashboard/statistics queries will error once this schema is in place unless their raw SQL is updated to the new table/column names.
Useful? React with 👍 / 👎.
Code ReviewStatus: DRAFT · +5528 / −477 · labels: API, Indexer OverviewThis PR introduces a new Envio/HyperIndex indexer (
Must-fix
Should-fix
Nits
Verification checklist
|
No description provided.