[FIX] Iso format for v3 is called twice#49
Conversation
| language: python | ||
| python: | ||
| - "2.7" | ||
| - "3.6" |
There was a problem hiding this comment.
why removing the 2.7 version?
| def create_iso8601_tz(): | ||
| ret = datetime.now(timezone.utc).isoformat()[:-13]+'Z' | ||
| return ret.isoformat() No newline at end of file | ||
| return datetime.now(timezone.utc).isoformat()[:-13]+'Z' No newline at end of file |
There was a problem hiding this comment.
that looks good, now that I look at the other code, it was indeed a strange setup.
lemoustachiste
left a comment
lemoustachiste
left a comment
There was a problem hiding this comment.
@lparkerlm can you weigh in on the removal of python 2.7?
lemoustachiste
left a comment
lemoustachiste
left a comment
There was a problem hiding this comment.
@flachica we had a discussion with @lparkerlm and as it stands, removing python 2.7 cannot be accepted as part of this PR. We need more time to flesh out the issue with this version, and decide if we maintain or remove support.
In my opinion your code looks ok, and if it works with Python 3, then I think it's good enough for the current purpose. Python 2.7 issue has been lingering for a while, so we would need to take a proper look at it.
As of this issue blockchain-certificates#48 and the PR blockchain-certificates#49 (paused for Python3 concerns) I proposte this PR to only put the correct datetime format without any Python3 upgrade
|
Updated without Python3 removal in #51 |
3 participants
No description provided.