add tweakable merkle tree and path#28
Open
bhaskar1001101 wants to merge 3 commits intoblockblaz:masterfrom
Open
add tweakable merkle tree and path#28bhaskar1001101 wants to merge 3 commits intoblockblaz:masterfrom
bhaskar1001101 wants to merge 3 commits intoblockblaz:masterfrom
Conversation
Member
|
add test cases |
Author
|
adding test cases here will lead to a circular dependency as the tests will need a ShaTweakHash from the hash-sigz lib. should be better to keep the test at https://github.com/blockblaz/hash-sigz/blob/sha-winternitz/src/tweak/tree.zig? |
Author
|
added test cases and abstracted away the tweakhash to https://github.com/bhaskar1001101/tweak-hash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hash size is not fixed to 32 and depends on the tweakable hash.
merkleizeWithTweak needs to return the entire merkle tree for the secret key. it allocates memory but might go against the design of the library? (mentioned in #17)
it is also generic over TweakHash instead of hasher as the zig-poseidon api is very different.
tests will have to be added in the hash-sigz lib as tweakable hash function is not available here directly.