fix: use immutable commit-SHA URLs in screenshot PR comments#842
Merged
Conversation
Image URLs in PR comments pointed at refs/heads/<branch>, a mutable ref that resolves to whatever the branch HEAD is at read time. When a later push for a different PR dropped files from the tree (race on fetch), all prior PR comments' images broke (404). Switch to raw.githubusercontent.com/<repo>/<commit-sha>/<path> so each comment's URLs are pinned to the exact commit that carried the blobs. Also chain commits with a parent so the branch has readable history.
michaelneale
added a commit
that referenced
this pull request
Jun 4, 2026
* origin/main: (36 commits) fix: use immutable commit-SHA URLs in screenshot PR comments (#842) feat(mobile+desktop): two-tier Slack-style app icon badge (#802) chore: simplify file-size check to a flat 1000-line limit (#839) fix(desktop): robust emoji picker — unify picker + fix custom emoji in editing, status, reactions (#837) feat(desktop): reusable screenshot workflow for agents (#826) desktop(mesh-llm): let a serving node route a different model (#833) chore(release): release version 0.3.9 (#832) fix: native arbitrary-file download + image context-menu flash (#830) fix(desktop): custom emoji reaction rendering + picker autofocus (#831) Mesh-LLM v1: relay-gated direct-iroh inference between users (WAN) (#822) chore(release): release version 0.3.8 (#829) chore(release): release version 0.3.7 (#825) feat: code block rendering, syntax highlighting, and compose fixes (#803) feat: custom emoji — user-owned NIP-30 sets with a client-side union (#816) Install sprout-cli skill at repo root + fix desktop clippy (#818) fix(desktop): use public re-export path for ensure_client_node_for_model (#824) refactor(desktop): feature-gate mesh-llm-sdk behind optional Cargo feature (#823) fix(desktop): align workflow read/save commands to the frontend contract (#820) fix(desktop): disable mesh-llm auto-build to prevent git config corruption (#819) fix(desktop): clear clippy lints in agents/mesh_llm commands (#817) ... # Conflicts: # Cargo.lock # desktop/scripts/check-file-sizes.mjs # desktop/src-tauri/Cargo.toml # desktop/src/app/AppShell.tsx # desktop/src/app/AppTopChrome.tsx # desktop/src/features/messages/hooks.ts # desktop/src/features/workspaces/useWorkspaceInit.ts # desktop/src/shared/api/tauri.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches
scripts/post-screenshots.shto use commit-SHA-basedraw.githubusercontent.comURLs instead of branch-ref URLs, so screenshot images in PR comments remain reachable permanently.Previously, image URLs pointed at
refs/heads/agent-screenshots/<user>, a mutable ref that resolves to whatever the branch HEAD is at read time. When a subsequent push for a different PR failed to preserve an earlier PR's files in the tree (due to a fetch-then-push race), all prior PR comments' images returned 404. This happened to the screenshots on #826 today — the PR #802 agent pushed a new tree with only its own files, silently dropping the #826 blobs.${REPO}/${COMMIT}after the push — each PR comment now references the exact commit that carries its blobs-pparent flag so theagent-screenshots/<user>branch has a readable linear history instead of a single-root orphan on every pushAGENTS.mdto drop the "orphan branch" description and note the immutability guarantee