Hide AI provider behind CoPlan::Ai facade (COPLAN-24)

engine/app/jobs/coplan/summarize_plan_job.rb

@@ -15,7 +15,7 @@ class SummarizePlanJob < ApplicationJob
 
     queue_as :default
 
-    discard_on AiProviders::OpenAi::Error
+    discard_on CoPlan::Ai::Error
 
     def perform(plan_id:)
       plan = Plan.find_by(id: plan_id)
@@ -37,7 +37,7 @@ def generate_summary(plan)
       content = plan.current_content
       return nil if content.blank?
 
-      AiProviders::OpenAi.call(
+      CoPlan::Ai.call(
         system_prompt: File.read(PROMPT_PATH),
         user_content: content
       ).to_s.strip.presence

engine/app/services/coplan/ai.rb

@@ -0,0 +1,23 @@
+module CoPlan
+  # Provider-agnostic facade for AI calls where the caller doesn't care
+  # which underlying provider runs the prompt. Use this from any place
+  # that just wants "an AI" (e.g. SummarizePlanJob).
+  #
+  # Provider-specific jobs that need to pin a model or provider per call
+  # (e.g. AutomatedReviewJob, where each reviewer is configured with its
+  # own provider+model) should keep calling AiProviders::OpenAi /
+  # AiProviders::Anthropic directly.
+  #
+  # The provider chosen here is an implementation detail; swap it without
+  # touching callers. Raises CoPlan::Ai::Error on provider failure so
+  # callers can `discard_on` without knowing which provider is in use.
+  module Ai
+    class Error < StandardError; end
+
+    def self.call(system_prompt:, user_content:)
+      AiProviders::OpenAi.call(system_prompt: system_prompt, user_content: user_content)
+    rescue AiProviders::OpenAi::Error => e
+      raise Error, e.message
+    end
+  end
+end

spec/jobs/summarize_plan_job_spec.rb

@@ -7,14 +7,14 @@
   let(:current_sha) { plan.current_plan_version.content_sha256 }
 
   before do
-    allow(CoPlan::AiProviders::OpenAi).to receive(:call).and_return("Fresh summary.")
+    allow(CoPlan::Ai).to receive(:call).and_return("Fresh summary.")
   end
 
   describe "#perform" do
-    it "passes the summarize prompt and plan content to the AI provider" do
+    it "passes the summarize prompt and plan content to CoPlan::Ai" do
       described_class.perform_now(plan_id: plan.id)
 
-      expect(CoPlan::AiProviders::OpenAi).to have_received(:call).with(
+      expect(CoPlan::Ai).to have_received(:call).with(
         system_prompt: File.read(CoPlan::SummarizePlanJob::PROMPT_PATH),
         user_content: plan.current_content
       )
@@ -32,7 +32,7 @@
     end
 
     it "strips whitespace from the AI response before persisting" do
-      allow(CoPlan::AiProviders::OpenAi).to receive(:call).and_return("  trimmed\n\n")
+      allow(CoPlan::Ai).to receive(:call).and_return("  trimmed\n\n")
 
       described_class.perform_now(plan_id: plan.id)
 
@@ -48,7 +48,7 @@
 
       described_class.perform_now(plan_id: plan.id)
 
-      expect(CoPlan::AiProviders::OpenAi).not_to have_received(:call)
+      expect(CoPlan::Ai).not_to have_received(:call)
       expect(plan.reload.summary).to eq("Existing.")
     end
 
@@ -65,7 +65,7 @@
     end
 
     it "does not update when the AI returns blank" do
-      allow(CoPlan::AiProviders::OpenAi).to receive(:call).and_return("   \n")
+      allow(CoPlan::Ai).to receive(:call).and_return("   \n")
 
       expect {
         described_class.perform_now(plan_id: plan.id)
@@ -77,7 +77,7 @@
 
       described_class.perform_now(plan_id: plan.id)
 
-      expect(CoPlan::AiProviders::OpenAi).not_to have_received(:call)
+      expect(CoPlan::Ai).not_to have_received(:call)
     end
 
     it "no-ops when the plan has been deleted" do
@@ -86,7 +86,7 @@
       expect {
         described_class.perform_now(plan_id: missing_id)
       }.not_to raise_error
-      expect(CoPlan::AiProviders::OpenAi).not_to have_received(:call)
+      expect(CoPlan::Ai).not_to have_received(:call)
     end
 
     # Race-condition guard: a slow job started against revision N must
@@ -97,7 +97,7 @@
       # Simulate "a newer version landed while the AI was thinking" by
       # mutating the plan's current_plan_version between the AI call and
       # the persist step.
-      allow(CoPlan::AiProviders::OpenAi).to receive(:call) do
+      allow(CoPlan::Ai).to receive(:call) do
         newer = create(:plan_version, plan: plan, revision: plan.current_revision + 1,
                                        content_markdown: "# Fresher\n\nNewer body.")
         plan.update!(current_plan_version: newer, current_revision: newer.revision,
@@ -113,9 +113,8 @@
       expect(plan.summary_content_sha256).not_to eq(stale_sha)
     end
 
-    it "discards on AI provider errors instead of retrying" do
-      allow(CoPlan::AiProviders::OpenAi).to receive(:call)
-        .and_raise(CoPlan::AiProviders::OpenAi::Error, "boom")
+    it "discards on AI errors instead of retrying" do
+      allow(CoPlan::Ai).to receive(:call).and_raise(CoPlan::Ai::Error, "boom")
 
       expect {
         perform_enqueued_jobs { described_class.perform_later(plan_id: plan.id) }

spec/services/ai_spec.rb

@@ -0,0 +1,26 @@
+require "rails_helper"
+
+RSpec.describe CoPlan::Ai do
+  describe ".call" do
+    it "delegates to AiProviders::OpenAi and returns its response" do
+      allow(CoPlan::AiProviders::OpenAi).to receive(:call).and_return("ai output")
+
+      result = described_class.call(system_prompt: "sys", user_content: "body")
+
+      expect(result).to eq("ai output")
+      expect(CoPlan::AiProviders::OpenAi).to have_received(:call).with(
+        system_prompt: "sys",
+        user_content: "body"
+      )
+    end
+
+    it "wraps provider errors in CoPlan::Ai::Error so callers don't know the provider" do
+      allow(CoPlan::AiProviders::OpenAi).to receive(:call)
+        .and_raise(CoPlan::AiProviders::OpenAi::Error, "rate limited")
+
+      expect {
+        described_class.call(system_prompt: "sys", user_content: "body")
+      }.to raise_error(CoPlan::Ai::Error, "rate limited")
+    end
+  end
+end