fix(desktop): widen post-Enter timeouts in empty-edit-delete spec - #4792
Merged
Conversation
The empty-edit-delete tests wait for either an alertdialog (empty-edit path) or edit-target to hide (non-empty edit path) after pressing Enter. Both transitions go through the React state update pipeline, which runs synchronously in isolation but can lag in a loaded shard under CI headless conditions. PR #4694 added huddle-transcription.spec.ts (477 lines, 22+ tests) to shard 2, shifting its composition so empty-edit-delete now runs after more accumulated browser state. The 5s timeouts became insufficient — the non-empty test failed 3/3 times in CI with edit-target still visible. Increase the three post-Enter wait timeouts from 5_000 to 10_000 to match the 10s pattern used elsewhere in the suite for slow-rendering assertions. No product logic is changed; this is a test-only fix. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wesbillman
approved these changes
Aug 4, 2026
wpfleger96
enabled auto-merge (squash)
August 4, 2026 21:08
wpfleger96
disabled auto-merge
August 4, 2026 21:08
shellz-n-stuff
added a commit
to shellz-n-stuff/buzz
that referenced
this pull request
Aug 4, 2026
…gent-instructions * origin/main: (30 commits) feat: Buzz entity links — rich preview cards + in-app navigation for repos, PRs, and issues (block#4695) fix(desktop): serialize tray channel actions for frontend (block#4762) chore(release): release Buzz Desktop version 0.5.5 (block#4788) feat(projects): support multiple repositories (block#4671) fix(ci): make desktop cache test version agnostic (block#4791) fix(desktop): widen post-Enter timeouts in empty-edit-delete spec (block#4792) fix(desktop): wait for terminal frame before splash (block#4781) fix(desktop): integer-align custom reaction emoji (block#4779) Polish Huddle voice controls (block#4694) fix(local-archive): default both archive settings to enabled (block#4750) fix(mobile): stop oversized read-state retry loop (block#4595) fix(desktop): close reconnect gaps that previously required CMD+R (block#4737) Dock Buzz Term within channel workspace (block#4724) perf(relay): index channel-id lookups and skip trace-only reads (block#4647) fix(agents): canonicalize stale persona harness pins (block#4631) Refine community invite links (block#4734) feat(desktop): persist sidebar observed-unread across webview reload (block#3976) feat(desktop): surface config diff in restart-required badge (block#3637) Polish sidebar unread hierarchy (block#4573) fix(desktop): show cached display names on startup (block#3317) ... Signed-off-by: Alex Rosenzweig <arosenzweig@squareup.com>
tellaho
pushed a commit
that referenced
this pull request
Aug 4, 2026
…er-snapshots * origin/main: Revert "chore(release): release Buzz Desktop version 0.5.5" (#4797) feat: Buzz entity links — rich preview cards + in-app navigation for repos, PRs, and issues (#4695) fix(desktop): serialize tray channel actions for frontend (#4762) chore(release): release Buzz Desktop version 0.5.5 (#4788) feat(projects): support multiple repositories (#4671) fix(ci): make desktop cache test version agnostic (#4791) fix(desktop): widen post-Enter timeouts in empty-edit-delete spec (#4792) fix(desktop): wait for terminal frame before splash (#4781) fix(desktop): integer-align custom reaction emoji (#4779) Polish Huddle voice controls (#4694) fix(local-archive): default both archive settings to enabled (#4750) fix(mobile): stop oversized read-state retry loop (#4595) Co-authored-by: npub14ndfusear8wdpe4kss8h7juc7wjk78atnqzf63zvppcpneknv4sq6x9370 <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: npub14ndfusear8wdpe4kss8h7juc7wjk78atnqzf63zvppcpneknv4sq6x9370 <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> # Conflicts: # desktop/src/features/communities/useCommunityInit.ts # desktop/src/shared/lib/linkPreview.test.mjs # desktop/src/shared/lib/linkPreview.ts # desktop/src/shared/lib/useResolvedLinkPreviews.ts # desktop/src/shared/ui/link-preview-attachment.tsx # desktop/src/shared/ui/markdown.tsx
sandro-sq
added a commit
that referenced
this pull request
Aug 4, 2026
* origin/main: (31 commits) feat: paste composer text without formatting (#4801) Revert "chore(release): release Buzz Desktop version 0.5.5" (#4808) chore(release): release Buzz Desktop version 0.5.5 (#4800) fix: reauthenticate databricks model discovery (#4008) Revert "chore(release): release Buzz Desktop version 0.5.5" (#4797) feat: Buzz entity links — rich preview cards + in-app navigation for repos, PRs, and issues (#4695) fix(desktop): serialize tray channel actions for frontend (#4762) chore(release): release Buzz Desktop version 0.5.5 (#4788) feat(projects): support multiple repositories (#4671) fix(ci): make desktop cache test version agnostic (#4791) fix(desktop): widen post-Enter timeouts in empty-edit-delete spec (#4792) fix(desktop): wait for terminal frame before splash (#4781) fix(desktop): integer-align custom reaction emoji (#4779) Polish Huddle voice controls (#4694) fix(local-archive): default both archive settings to enabled (#4750) fix(mobile): stop oversized read-state retry loop (#4595) fix(desktop): close reconnect gaps that previously required CMD+R (#4737) Dock Buzz Term within channel workspace (#4724) perf(relay): index channel-id lookups and skip trace-only reads (#4647) fix(agents): canonicalize stale persona harness pins (#4631) ... Signed-off-by: Alessandro Joabar <sandro@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increases three Playwright assertion timeouts in
tests/e2e/empty-edit-delete.spec.tsfrom 5s to 10s to fix a shard-composition flake introduced by PR #4694.Root Cause
PR #4694 added
huddle-transcription.spec.ts(477 lines, 22+ tests) to the Desktop Smoke E2E suite, shifting shard 2 composition so thatempty-edit-deletenow runs with significantly more accumulated browser state. The three affected assertions all wait for a React state update triggered by pressing Enter in edit mode:alertdialogbecoming visible after an empty edit (tests 1 and 2)edit-targethiding after a successful non-empty edit (test 3)These transitions go through the React scheduler. In isolation they complete in milliseconds. In a loaded headless shard with accumulated GC pressure, the 5s window became insufficient — test 3 failed 3/3 times in CI run 30946444168 with
edit-targetstill visible after Enter.No product code is changed. The empty-edit-delete flow is correct and untouched by #4694. This is a test-environment timing adjustment only.
What Changed
tests/e2e/empty-edit-delete.spec.ts— three{ timeout: 5_000 }→{ timeout: 10_000 }for the post-Enter React-update waitsValidation
just desktop-check— passedjust desktop-test— 4194 passed, 0 failed