-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Expose allowlist respond-to mode in buzz agents draft-update #4725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -245,6 +245,8 @@ enum Cmd { | |
| pub enum RespondToArg { | ||
| #[value(name = "owner-only")] | ||
| OwnerOnly, | ||
| #[value(name = "allowlist")] | ||
| Allowlist, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The reviewed commit message contains no AGENTS.md reference: AGENTS.md:L111-L111 Useful? React with 👍 / 👎. |
||
| #[value(name = "anyone")] | ||
| Anyone, | ||
| } | ||
|
|
@@ -253,6 +255,7 @@ impl RespondToArg { | |
| fn to_wire(self) -> String { | ||
| match self { | ||
| Self::OwnerOnly => "owner-only", | ||
| Self::Allowlist => "allowlist", | ||
| Self::Anyone => "anyone", | ||
| } | ||
| .to_string() | ||
|
|
@@ -294,6 +297,9 @@ pub enum AgentsCmd { | |
| model: Option<String>, | ||
| #[arg(long, value_enum)] | ||
| respond_to: Option<RespondToArg>, | ||
| /// Pubkey allowed to trigger the agent when --respond-to=allowlist (hex, repeatable) | ||
| #[arg(long = "respond-to-allowlist")] | ||
| respond_to_allowlist: Vec<String>, | ||
| }, | ||
| /// Submit a NIP-IA archive request for an identity (kind 9035) | ||
| #[command( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,10 @@ function updateInputFromRequest( | |
| ? { | ||
| behavior: { | ||
| respondTo: changes.respondTo, | ||
| respondToAllowlist: [], | ||
| respondToAllowlist: | ||
| changes.respondTo === "allowlist" | ||
| ? (changes.respondToAllowlist ?? []) | ||
| : [], | ||
|
Comment on lines
+52
to
+55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This changes how allowlist configuration is applied to the owner-reviewed edit draft, but the commit neither updates the scoped AGENTS.md reference: desktop/src/features/agents/AGENTS.md:L184-L191 Useful? React with 👍 / 👎. |
||
| parallelism: current.behavior?.parallelism, | ||
| }, | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new public
UpdateAgentDraft::respond_to_allowlistfield has no Rust doc comment; the same is true of the newly publicRespondToArg::Allowlistvariant atcrates/buzz-cli/src/lib.rs:249. Add API documentation for these newly exposed items as required by the repository contributor contract.AGENTS.md reference: AGENTS.md:L113-L116
Useful? React with 👍 / 👎.