Skip to content

fix(desktop): show cross-desktop managed agents in @mention autocomplete #4714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anindyar wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −5
Open

fix(desktop): show cross-desktop managed agents in @mention autocomplete #4714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions desktop/src/features/agents/lib/agentAutocompleteEligibility.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,26 @@ test("shouldHideAgentFromMentions: shows member agents with unknown invocability
);
});

test("shouldHideAgentFromMentions: #4187 shows a channel-member agent managed by another Desktop instance", () => {
// Regression for #4187: a managed agent running on another Desktop instance
// appears here as a channel member (isAgent via role "bot") that is neither
// in this client's managed-agent list nor in the relay directory
// (mentionableAgentPubkeys/directoryAgentPubkeys both empty). It MUST remain
// visible in the mention picker. The mention path (useMentions) must rely on
// this policy alone and not additionally pre-filter with
// isAgentIdentityInManagedList, which would drop it.
assert.equal(
shouldHideAgentFromMentions({
isAgent: true,
isMember: true,
pubkey: PUB_A,
mentionableAgentPubkeys: new Set(),
directoryAgentPubkeys: new Set(),
}),
false,
);
});

test("shouldHideAgentFromMentions: normalizes the pubkey before lookup", () => {
const mixedCase = "Ab".repeat(32);
const normalized = mixedCase.toLowerCase();
Expand Down
15 changes: 10 additions & 5 deletions desktop/src/features/messages/lib/useMentions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
coalesceAutocompleteCandidatesByKey,
getMentionableAgentPubkeys,
getSharedChannelIds,
isAgentIdentityInManagedList,
shouldHideAgentFromMentions,
} from "@/features/agents/lib/agentAutocompleteEligibility";
import {
Expand Down Expand Up @@ -246,9 +245,16 @@ export function useMentions(
if (isArchivedDiscovery(pubkey)) {
return;
}
if (!isAgentIdentityInManagedList(candidate, managedAgentPubkeys)) {
return;
}
// Agent visibility in the mention picker is governed solely by
// `shouldHideAgentFromMentions` (the "Option B" member/directory policy
// below). We deliberately do NOT pre-filter with
// `isAgentIdentityInManagedList` here: that gate keeps only *locally*
// managed agents, which drops channel-member agents managed by another
// Desktop instance before the member/directory policy can show them —
// the root cause of #4187 (cross-desktop managed agents missing from the
// `@mention` autocomplete). `isAgentIdentityInManagedList` still belongs
// in the "add member" search (MembersSidebar), where you may only add
// agents you manage; it does not belong on the mention path.
if (
shouldHideAgentFromMentions({
isAgent: candidate.isAgent === true,
Expand Down Expand Up @@ -420,7 +426,6 @@ export function useMentions(
managedAgentNamesByPubkey,
managedAgentPersonaIds,
managedAgentPersonaIdsByPubkey,
managedAgentPubkeys,
managedAgentsQuery.data,
memberPubkeys,
members,
Expand Down