deps(dashboard): vitest 4, closing the one critical alert in the queue - #92
Closed
blitzcrieg1 wants to merge 1 commit into
Closed
deps(dashboard): vitest 4, closing the one critical alert in the queue#92blitzcrieg1 wants to merge 1 commit into
blitzcrieg1 wants to merge 1 commit into
Conversation
Dependabot #68 proposed this and could not land it. Its lockfile went stale against master twice while other merges moved underneath it, and both CI runs failed at `npm ci` on a sync error rather than on anything to do with vitest. Rebasing a third time would have raced the same way, so this does the upgrade directly. It is the only critical in the alert queue. The advisory needs 3.2.6 or later and this goes to 4.1.11. Worth noting it was never reachable here: the CVE requires the Vitest UI server to be listening, which it is not during `vitest run` in CI or locally. 99 tests pass unchanged, no test file needed editing. tsc clean, lint clean, static export builds. @vitejs/plugin-react now warns that its `esbuild` options are deprecated in favour of `oxc`. That is the plugin's problem rather than ours and it is a warning, not a failure. Dependabot has a plugin bump open; it can carry the fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Closing in favour of #90, which is strictly better. Mine did vitest 2.1.9 to 4.1.11. #90 does that plus Same critical alert closed, one fewer warning, one fewer PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #68.
Dependabot proposed this and could not land it. Its lockfile went stale against master twice while other merges moved underneath it, and both CI runs failed at
npm ciwith a sync error rather than on anything to do with vitest:A third rebase would have raced the same way, so this does the upgrade directly.
It is the only critical in the queue
The advisory needs 3.2.6 or later; this goes to 4.1.11.
Worth stating plainly: it was never reachable here. The CVE requires the Vitest UI server to be listening, which it is not during
vitest runin CI or locally. Closing it is hygiene, not incident response.Verified
tsc --noEmitcleanOne warning it surfaces
@vitejs/plugin-reactnow warns itsesbuildoptions are deprecated in favour ofoxc. That is the plugin's problem, it is a warning rather than a failure, and Dependabot has a plugin bump open that can carry the fix.🤖 Generated with Claude Code