Skip to content

Add support for Color names#48

Open
angusm wants to merge 1 commit into
blinkk:masterfrom
angusm:feature/color-name-support
Open

Add support for Color names#48
angusm wants to merge 1 commit into
blinkk:masterfrom
angusm:feature/color-name-support

Conversation

@angusm

@angusm angusm commented Nov 29, 2020

Copy link
Copy Markdown
Member

This might be a call on weight, whether we want to have this functionality for users or insist on HEX/RGB values instead.

@uxder

uxder commented Nov 29, 2020

Copy link
Copy Markdown
Member

Thanks Angus for adding this.

@jeremydw @stevenle Do you have an opinion on this? I personally never use color names so am thinking we perhaps omit it but we can include it if others find useful.

@stevenle

Copy link
Copy Markdown
Member

i personally would prefer to keep the library small (in size and in memory usage) and the map looks fairly big for functionality that could be moved to where it's being called.

@jeremydw

jeremydw commented Nov 30, 2020 via email

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants