Core 5889 - #12
Open
abdyfranco wants to merge 3 commits into
Open
Conversation
added 2 commits
August 12, 2026 15:36
<?= only works where short_open_tag is enabled, so the page listing and the manage form could render their markup as literal text on a server that has it off. Spells them out as <?php echo instead, matching the rest of the plugin. Also guards the language loop in the manage form against a missing $languages.
The portal renders through the active client template already, since Main::preAction()
points the structure at client/{template}, and the page markup itself lives in cms_pages.
What did not follow was views/default/css/styles.css, which paints the portal boxes and the
install notice in fixed colors. Against Meridian's dark palette that left white cards on a
dark page, and an install notice whose inherited near-white text sat on a white background.
Adds views/meridian/, resolved per file through PluginViewResolver, holding the portal view
and a stylesheet that takes its colors from the Meridian design tokens, so light and dark
mode need no extra rules. Also carries the FontAwesome sizing classes: Meridian maps the
FontAwesome class names onto Bootstrap Icons glyphs but ships none of fa-lg through fa-5x,
so the fa-4x icons on the seeded portal page were drawing at 1em.
The stylesheet link is built in preAction, before the view directory is settled, so it was
always pointing at views/default/ no matter which directory the view came from. It now
resolves the directory the same way the renderer does.
The admin views are left on views/default/, which the admin template goes on using.
…lates The two client structures include stylesheets in mutually exclusive ways. Meridian renders the Css helper and carries no custom_head at all, while the Bootstrap template is the other way around, so the link set here reached the head on one and was silently discarded on the other. Meridian dropped custom_head as of core 5e7cfa300, which left the portal page with none of the plugin stylesheet: the portal boxes and the install notice rendered unstyled, including the dark mode rules views/meridian/css/styles.css exists to provide. The Meridian view now loads the stylesheet itself, where $this->view_dir is already the directory the view resolved to, and setting custom_head is left to the templates that render it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.