Fix browser popup not appearing on login sync#18
Merged
Conversation
Owner
bladnman
commented
Dec 5, 2025
bladnman
commented
- Fix OAuth flow blocking the async runtime by using spawn_blocking for the TCP listener that waits for the callback
- Change default hotkey from Cmd+Shift+Space to Cmd+/
- Add session-level caching for accessibility permission prompts to avoid repeatedly showing the dialog on each paste attempt
- Fix OAuth flow blocking the async runtime by using spawn_blocking for the TCP listener that waits for the callback - Change default hotkey from Cmd+Shift+Space to Cmd+/ - Add session-level caching for accessibility permission prompts to avoid repeatedly showing the dialog on each paste attempt
The previous Select All fix worked in Playwright tests but failed in the actual Tauri app because WKWebView intercepts Cmd+A at the native level before JavaScript receives the event. Additionally, CodeMirror's virtualization only renders visible lines, causing partial selections. This fix implements multiple strategies: - Detect partial selections via selectionchange event - Auto-fix by extending selection to full document via CodeMirror dispatch - Persist full selection state across scroll events (re-apply as user scrolls) - Use setTimeout and requestMeasure to ensure proper visual updates Also adds comprehensive E2E tests that load existing prompts (not create new) to properly test virtualization behavior, running in both Chromium and WebKit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bladnman
deleted the
claude/fix-login-sync-popup-01JFvnAfx8Yp7hTtSWjh6fHV
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.