fix(types): extract ContextMenuItemConfig to remove role support from context menus#184
Open
omarghandour wants to merge 1 commit intoblackboardsh:mainfrom
Open
fix(types): extract ContextMenuItemConfig to remove role support from context menus#184omarghandour wants to merge 1 commit intoblackboardsh:mainfrom
omarghandour wants to merge 1 commit intoblackboardsh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a TODO inside
ContextMenu.ts.Context Menus should not share the exact same configuration type as Native Application Menus because application menus support the
roleproperty whereas context menus do not. This PR extracts a sharedBaseMenuItemConfigand separates theApplicationMenuItemConfigandContextMenuItemConfigto restrictroleusage to application menus only.Tested locally via the
kitchensink application to ensure context menus still compile and render successfully.