Improve shell path escaping in CLI to prevent command injection#176
Open
RinZ27 wants to merge 1 commit intoblackboardsh:mainfrom
Open
Improve shell path escaping in CLI to prevent command injection#176RinZ27 wants to merge 1 commit intoblackboardsh:mainfrom
RinZ27 wants to merge 1 commit intoblackboardsh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability in path escaping was noticed where only double quotes were being handled. Since the CLI uses string templates with shell-execution functions like execSync, characters such as backticks or dollar signs in file paths could lead to arbitrary command execution on a developer's machine.
Switching to single quotes for POSIX systems provides a much more robust shield against shell expansion. While double quotes still allow for variable interpolation and command substitution, single quotes neutralize these threats entirely. Additionally, several locations using direct double-quote wrapping were refactored to use the centralized escape utility.
Safety of the build process is significantly improved by this change, especially when dealing with projects or paths containing special characters. My tests confirmed that standard paths continue to work correctly while malicious paths are now safely escaped and do not trigger unexpected shell behavior.